-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] payment providers: Wire Transfer #4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be interesting to mention that there is a mechanism to auto-generate the communication with the prefilled bank account numbers.
The mechanism works as follows: when the acquirer is created or when the communication field is erased, the available bank accounts are fetched, and the communication is generated. If no bank account is found, the communication is still generated, but the user must complete a sort of "text à trous" with their bank number. Starting with 16.1, there is a "Reload Pending Message" that allows regenerating the communication without clearing it first.
LoredanaLrpz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @auva-odoo, great work on this :)
The doc doesn't mention the QR code feature, I think it could be useful to mention (even though it's just a box to check, it's part of the configuration process (cf. picture pt. 1)
Also, I think it could be interesting to add a seealso to a payment journal doc (this page kinda talk about it, but not really so I'm not sure about that point: https://www.odoo.com/documentation/14.0/applications/finance/accounting/getting_started/cheat_sheet.html#accounting-cheat-sheet )
content/applications/finance/payment_acquirers/wire_transfer.rst
Outdated
Show resolved
Hide resolved
eab7fb7 to
0575acb
Compare
jcs-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I just had a look at your PR (and renamed it according to your commit message)
About images:
didn't you prefer no alignment of the images? Imo, that would look better without it, especially since these images are part of list elements.
Also, are the screenshots of the backend made in master? This way you don't have to update them during the fw-porting.
What about the points raised by @AntoineVDV and @LoredanaLrpz ? I don't know if you decided to add them later (no note here or in the task)
Cheers :)
content/applications/finance/payment_acquirers/wire_transfer.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/payment_acquirers/wire_transfer.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/payment_acquirers/wire_transfer.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/payment_acquirers/wire_transfer.rst
Outdated
Show resolved
Hide resolved
0575acb to
ecf526b
Compare
|
taskid-3301001
ecf526b to
6a9533c
Compare
jcs-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
|
@auva-odoo @jcs-odoo staging failed: ci/runbot on 5211109a182c770a34e4656ff8458ae56ed3935f (view more at https://runbot.odoo.com/runbot/build/40765321) |
|
@robodoo retry |
taskid-3301001 closes #4445 Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
|
@auva-odoo @jcs-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
|
@auva-odoo @jcs-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@auva-odoo @jcs-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@auva-odoo @jcs-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |

No description provided.