Skip to content

Conversation

@auva-odoo
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented May 17, 2023

@auva-odoo auva-odoo marked this pull request as draft May 17, 2023 08:08
@auva-odoo auva-odoo changed the base branch from 16.0 to 14.0 May 17, 2023 08:09
@auva-odoo auva-odoo marked this pull request as ready for review May 17, 2023 08:10
@C3POdoo C3POdoo requested a review from a team May 17, 2023 08:10
@auva-odoo auva-odoo requested a review from LoredanaLrpz May 17, 2023 08:18
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be interesting to mention that there is a mechanism to auto-generate the communication with the prefilled bank account numbers.

The mechanism works as follows: when the acquirer is created or when the communication field is erased, the available bank accounts are fetched, and the communication is generated. If no bank account is found, the communication is still generated, but the user must complete a sort of "text à trous" with their bank number. Starting with 16.1, there is a "Reload Pending Message" that allows regenerating the communication without clearing it first.

Copy link
Contributor

@LoredanaLrpz LoredanaLrpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @auva-odoo, great work on this :)

The doc doesn't mention the QR code feature, I think it could be useful to mention (even though it's just a box to check, it's part of the configuration process (cf. picture pt. 1)

Also, I think it could be interesting to add a seealso to a payment journal doc (this page kinda talk about it, but not really so I'm not sure about that point: https://www.odoo.com/documentation/14.0/applications/finance/accounting/getting_started/cheat_sheet.html#accounting-cheat-sheet )

image

@auva-odoo auva-odoo force-pushed the 14.0-wire-transfers-auva branch 2 times, most recently from eab7fb7 to 0575acb Compare May 23, 2023 12:11
@LoredanaLrpz LoredanaLrpz self-requested a review May 24, 2023 13:00
@LoredanaLrpz LoredanaLrpz requested a review from a team May 24, 2023 15:21
@jcs-odoo jcs-odoo changed the title 14.0 wire transfers auva [IMP] payment providers: Wire Transfer May 25, 2023
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I just had a look at your PR (and renamed it according to your commit message)

About images:
didn't you prefer no alignment of the images? Imo, that would look better without it, especially since these images are part of list elements.

Also, are the screenshots of the backend made in master? This way you don't have to update them during the fw-porting.

What about the points raised by @AntoineVDV and @LoredanaLrpz ? I don't know if you decided to add them later (no note here or in the task)

Cheers :)

@auva-odoo auva-odoo force-pushed the 14.0-wire-transfers-auva branch from 0575acb to ecf526b Compare May 25, 2023 11:36
@auva-odoo
Copy link
Contributor Author

auva-odoo commented May 25, 2023

@jcs-odoo

  • I do prefer no alignment of the images, but since the images are center-aligned in the other payment provider pages, I decided to stick to it for this one as well for consistency.
  • I will redo the screenshot from 16.1 beause I want to show the "Reload pending message" feature.
  • As for the rest: Enable QR code will be documented in 15.0 and I will mention the automatic generation of the message in 16.0 + Reload message in 16.1.

@auva-odoo auva-odoo requested a review from jcs-odoo May 25, 2023 11:44
@auva-odoo auva-odoo force-pushed the 14.0-wire-transfers-auva branch from ecf526b to 6a9533c Compare May 25, 2023 11:50
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Collaborator

robodoo commented May 25, 2023

@auva-odoo @jcs-odoo staging failed: ci/runbot on 5211109a182c770a34e4656ff8458ae56ed3935f (view more at https://runbot.odoo.com/runbot/build/40765321)

@auva-odoo
Copy link
Contributor Author

@robodoo retry

robodoo pushed a commit that referenced this pull request May 25, 2023
taskid-3301001

closes #4445

Signed-off-by: Castillo Jonathan (jcs) <jcs@odoo.com>
@robodoo robodoo temporarily deployed to merge May 25, 2023 15:40 Inactive
@robodoo robodoo closed this May 25, 2023
@fw-bot
Copy link
Collaborator

fw-bot commented May 29, 2023

@auva-odoo @jcs-odoo this pull request has forward-port PRs awaiting action (not merged or closed):
#4563

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented May 30, 2023

@auva-odoo @jcs-odoo this pull request has forward-port PRs awaiting action (not merged or closed):
#4563

@fw-bot
Copy link
Collaborator

fw-bot commented May 31, 2023

@fw-bot
Copy link
Collaborator

fw-bot commented Jun 1, 2023

@auva-odoo @jcs-odoo this pull request has forward-port PRs awaiting action (not merged or closed):
#4563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants