[ADD] PLM: engineering change order doc #5238

Felicious · 2023-08-01T20:20:37Z

Summary

Create a new doc that details:

How to create new ECOs in 3 ways (normal way, tablet view, from an email alias)
Overview of ECO types and stages
How to close/apply changes to an ECO

Looking for feedback (in particular) on document organizational structure: given the flow of using ECOs, do the section titles make sense? Are they in an order that makes most sense?

And of course, I welcome feedback on any wording, brevity, accuracy of the flow suggestions 😄

robodoo · 2023-08-01T20:21:07Z

Pull request status dashboard.

hojo-odoo

Hey @Felicious,

Good job on this. I've made a few comments that should be applied throughout the doc. Also, one of the .rst files is missing a blank line at the end.

Thanks,
hojo

content/applications/inventory_and_mrp/manufacturing/plm/engineering_change_orders.rst

Felicious · 2023-08-04T16:43:25Z

Hello @odoo/crm-doc-review (: This Product management lifecycle (PLM) doc is ready for the second round of peer review! If you get to this before 8/10, that's amazing because that's when I'll be asking an MRP expert from support to do another review. It'll be so nice if ya'll are able to help me make the doc sound snappier 😊 If not, that's okay! You'll be reviewing an even more accurate and detailed doc 😄

Thanks in advance for your help!

odoo-shke

Looks good!

content/applications/inventory_and_mrp/manufacturing/plm/engineering_change_orders.rst

ksc-odoo

Alrighty @Felicious just finished with my Peer Review - fantastic work! Only had a handful of minor suggestions - but other than that, everything looks great! Nice job! 👍

content/applications/inventory_and_mrp/manufacturing/management/bill_configuration.rst

content/applications/inventory_and_mrp/manufacturing/plm.rst

content/applications/inventory_and_mrp/manufacturing/plm/engineering_change_orders.rst

Felicious · 2023-08-23T21:22:31Z

Hi @ksc-odoo!! Thanks for reviewing my doc (: Do you see this message?

Felicious · 2023-08-23T21:49:29Z

Hello @odoo/us-doc-review 😄

This PLM doc is ready for your review! Thank you in advance for your help.

content/applications/inventory_and_mrp/manufacturing/plm.rst

content/applications/inventory_and_mrp/manufacturing/plm/engineering_change_orders.rst

content/applications/inventory_and_mrp/manufacturing/plm.rst

content/applications/inventory_and_mrp/manufacturing/plm/engineering_change_orders.rst

StraubCreative · 2023-09-18T22:21:28Z

@ksc-odoo @hojo-odoo think this could use another round of peer review so I'm kicking back to you.
There are content and proofreading issues (terms not being defined, UI not being covered, capitalization/formatting inconsistencies, etc). Can you both take another look, please?

StraubCreative

@Felicious approving with some small comments.
Merge when ready, thanks!

@robodoo delegate=Felicious

StraubCreative · 2023-11-01T23:28:45Z

content/applications/inventory_and_mrp.rst

    inventory_and_mrp/barcode
    inventory_and_mrp/quality
    inventory_and_mrp/maintenance
+    inventory_and_mrp/plm


Small thing I noticed:
The toctree links in this doc aren't exactly lined up with the indentation of the tag 😄

content/applications/inventory_and_mrp/manufacturing/management/bill_configuration.rst

StraubCreative · 2023-11-01T23:32:02Z

content/applications/inventory_and_mrp/plm/manage_changes.rst

+   manage_changes/eco_type
+   manage_changes/engineering_change_orders


would switch the order of these since ECO doc introducing the concept would ideally come first.
fwiw doc content is not organized alphabetically in English.

StraubCreative · 2023-11-01T23:35:48Z

content/applications/inventory_and_mrp/plm/manage_changes/engineering_change_orders.rst

+   Step` pop-up window. Doing so creates an instructional quality control point that will be
+   reviewed in the following section.
+
+   .. image:: engineering_change_orders/add-a-step.png


is this image compressed?

no, updating! thanks for catching that

StraubCreative · 2023-11-01T23:36:11Z

content/applications/inventory_and_mrp/plm/manage_changes/engineering_change_orders.rst

+   Materials` radio button is selected in the :guilabel:`Apply on` field, and the :guilabel:`Start
+   Revision` button has been pressed.
+
+.. image:: engineering_change_orders/eco-form.png


same here— is this compressed?

thanks for catching that!

StraubCreative · 2023-11-01T23:37:29Z

content/applications/inventory_and_mrp/plm/manage_changes/engineering_change_orders.rst

+   Drag and reorder the `Check for broken switches` instruction, by clicking and dragging its "6
+   dots" icon to move it from the bottom to the second position.
+
+   .. image:: engineering_change_orders/reorder.png


this one doesn't appear to be compressed given how small the dimensions are

Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com> Co-authored-by: Sho Ketchum <96748231+odoo-shke@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Zachary Straub <zst@odoo.com>

Felicious · 2023-11-02T01:57:16Z

@robodoo r+

Felicious self-assigned this Aug 1, 2023

Felicious added the 16.0 label Aug 1, 2023

C3POdoo requested a review from a team August 1, 2023 20:21

tiku-odoo self-requested a review August 1, 2023 20:32

Felicious force-pushed the 16.0-plm-eco-feku branch from 80e154b to 3ea0863 Compare August 1, 2023 20:33

Felicious removed the 16.0 label Aug 2, 2023

tiku-odoo removed their request for review August 2, 2023 13:41

brse-odoo self-requested a review August 2, 2023 17:15

hojo-odoo reviewed Aug 2, 2023

View reviewed changes

brse-odoo removed their request for review August 3, 2023 12:27

Felicious force-pushed the 16.0-plm-eco-feku branch from 9dae96c to cb49c41 Compare August 3, 2023 21:28

Felicious mentioned this pull request Aug 3, 2023

[ADD] version control doc #5262

Closed

Felicious force-pushed the 16.0-plm-eco-feku branch from cb49c41 to b48e20f Compare August 3, 2023 23:05

Felicious requested a review from a team August 4, 2023 15:11

Felicious mentioned this pull request Aug 7, 2023

[ADD] PLM: approvals doc #5348

Closed

odoo-shke reviewed Aug 10, 2023

View reviewed changes

Felicious force-pushed the 16.0-plm-eco-feku branch from 77118d2 to bb8c26f Compare August 22, 2023 17:39

ksc-odoo reviewed Aug 22, 2023

View reviewed changes

Felicious force-pushed the 16.0-plm-eco-feku branch from 3d55248 to 6b95b31 Compare August 23, 2023 21:18

Felicious force-pushed the 16.0-plm-eco-feku branch from cab41d7 to ff4db9e Compare August 23, 2023 21:46

Felicious requested a review from a team August 23, 2023 21:47

Felicious commented Aug 30, 2023

View reviewed changes

content/applications/inventory_and_mrp/manufacturing/plm.rst Show resolved Hide resolved

StraubCreative requested changes Sep 18, 2023

View reviewed changes

StraubCreative requested review from hojo-odoo and ksc-odoo September 18, 2023 22:21

Felicious force-pushed the 16.0-plm-eco-feku branch 3 times, most recently from e4d74b0 to 95122af Compare October 11, 2023 21:18

StraubCreative requested review from a team and removed request for StraubCreative November 1, 2023 17:36

StraubCreative approved these changes Nov 1, 2023

View reviewed changes

Felicious force-pushed the 16.0-plm-eco-feku branch from 7da4352 to 20b555c Compare November 2, 2023 01:53

robodoo closed this in fc9bbb7 Nov 2, 2023

robodoo temporarily deployed to merge November 2, 2023 02:55 Inactive

		manage_changes/eco_type
		manage_changes/engineering_change_orders

[ADD] PLM: engineering change order doc #5238

[ADD] PLM: engineering change order doc #5238

Uh oh!

Conversation

Felicious commented Aug 1, 2023

Summary

Uh oh!

robodoo commented Aug 1, 2023

Uh oh!

hojo-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious commented Aug 4, 2023

Uh oh!

odoo-shke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksc-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Felicious commented Aug 23, 2023

Uh oh!

Felicious commented Aug 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StraubCreative commented Sep 18, 2023

Uh oh!

StraubCreative left a comment

Choose a reason for hiding this comment

Uh oh!

StraubCreative Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StraubCreative Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

StraubCreative Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

Felicious Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

StraubCreative Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!