Skip to content

[ADD] PLM: approvals doc #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ADD] PLM: approvals doc #5348

wants to merge 1 commit into from

Conversation

@Felicious
Copy link
Contributor

@Felicious Felicious commented Aug 7, 2023

Summary

Create a new PLM doc detailing:

  1. How to add approvers
  2. A workflow of accepting/rejecting ECOs
  3. Odoo's automatic planned activity creation for approvers

Note for reviewers: there are a few custom anchors that can't be found, and they are to links in the ECO doc . This PR should be pushed AFTER the ECO PR is pushed, so the links will work accordingly.

@Felicious Felicious self-assigned this Aug 7, 2023
@Felicious Felicious requested a review from a team August 7, 2023 23:57
@robodoo
Copy link
Collaborator

robodoo commented Aug 7, 2023

Pull request status dashboard.

@Felicious
Copy link
Contributor Author

Felicious commented Aug 7, 2023

Hello @odoo/manufacturing-doc-review! This is the last PLM doc for Tim's whitepaper 😄 Yayy we're done adding PLM docs! Thank you for the peer review 😃

odoo-shke
odoo-shke reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@odoo-shke odoo-shke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@Felicious Felicious mentioned this pull request Sep 18, 2023
Closed
@StraubCreative
Copy link
Contributor

StraubCreative commented Sep 18, 2023

@odoo/manufacturing-doc-review review this asap please :)

hojo-odoo
hojo-odoo reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Felicious,

Great job on this. I left some suggestions, mostly related to phrasing improvements. Also, make sure that |ECO| and |ECOs| appear with the lines on each side every time they're written.

Thanks,
hojo

@Felicious Felicious force-pushed the 16.0-plm-approvals-feku branch from 9aba181 to de874a6 Compare October 12, 2023 23:53
@Felicious
Copy link
Contributor Author

Felicious commented Oct 13, 2023

Hi @odoo/crm-doc-review 😄

This PLM doc is ready for your review! Just letting you know that there should be 4 build errors, related to missing files/custom anchors for the engineering change orders and version control docs that should be published before this one.

Anyways, thank you in advance for giving this doc a review! 😁

@Felicious Felicious requested a review from a team October 13, 2023 01:28
@Felicious Felicious force-pushed the 16.0-plm-approvals-feku branch from de874a6 to 5995d2e Compare October 13, 2023 01:30
@Felicious Felicious changed the title [ADD] ECO approvals doc [ADD] PLM: approvals doc Oct 13, 2023
@C3POdoo C3POdoo requested review from a team October 13, 2023 01:31
ksc-odoo
ksc-odoo reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Felicious -- just finished my peer review of this PR and only had a few minor suggestions that'll need your attention. But, once you give those a look, I think this will be ready for the next stage. Once again, Awesome Job with this one! 👍

@Felicious Felicious force-pushed the 16.0-plm-approvals-feku branch from a8ab255 to b1844cd Compare November 3, 2023 16:38
StraubCreative
StraubCreative approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great doc @Felicious 🤙

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Nov 3, 2023

@Felicious @StraubCreative unable to stage: merge conflict

@Felicious @hojo-odoo
@ksc-odoo @StraubCreative
[ADD] PLM: ECO approvals doc
dab5446 
Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: Zachary Straub (zst) <zst@odoo.com>
@Felicious Felicious force-pushed the 16.0-plm-approvals-feku branch from b1844cd to dab5446 Compare November 6, 2023 18:44
@StraubCreative
Copy link
Contributor

StraubCreative commented Nov 6, 2023

@robodoo r+

@robodoo robodoo closed this in 907e1ba Nov 6, 2023
This was referenced Nov 6, 2023
Closed
Closed
Closed
This was referenced Nov 6, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

+3 more reviewers

@ksc-odoo ksc-odoo ksc-odoo left review comments

@odoo-shke odoo-shke odoo-shke left review comments

@hojo-odoo hojo-odoo hojo-odoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Felicious Felicious

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Felicious @robodoo @StraubCreative @ksc-odoo @odoo-shke @hojo-odoo