-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] fleet: create new vehicles #5759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Waiting for some feedback/answers from Quentin so this doc can be finished- not ready for review yet. |
34cde92 to
d22f586
Compare
|
Hi @jcs-odoo - can you help with the codeowner issue? This is a new doc for a new app (no previous doc existed for fleet). |
Hi @larm-odoo ! All good for the codeowner team I haven't read the doc, but I saw the title "Add a vehicle". Usually, we try to avoid verbs in titles. --> https://www.odoo.com/documentation/master/contributing/documentation/content_guidelines.html#titles-and-headings When we explain a record on a documentation page, it is not only to add a new record from scratch (like we explain in video tutorials, for example), but mostly to describe how it works in general, as a reference (which can be both to create a new record, view or edit an existing one). I hope this is helpful. Have a good day :) |
d22f586 to
6eb4cf4
Compare
|
Thank you @jcs-odoo - I had tagged you at the suggestion of a coworker when I got the original error, but I am glad it was a non-issue! As for the name, thank you for pointing that out, and I have updated it so it is in a better format =) |
jero-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @larm-odoo, only a few notes. Let me know if you have any questions. Thanks!
6eb4cf4 to
3efb319
Compare
|
Hi @tiku-odoo - this is set for the 2nd peer review! |
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start to this doc- I like the definitions you've compiled. However, I think this doc needs some intros to each section, so it isn't textbook. I've left a few comments on things to change. Notable-- it isn't the calendar module the dropdown/selector is populating. It is just a standard date selector. We should not be using the word "module." A module in Odoo is an application or set of Python instructions to be executed. All this does is select a date unless I am missing something.
Creating a company deserves a warning admonition block. This causes subscriptions to go up $$$ and potentially shut a database down if they don't resolve the upsell.
A few other questions - Are there any links with the accounting app? I see a lot of data input here.
Loop me back in for a quick review once you've made the changes. Thanks 👍
Tim
| To add a new vehicle to the fleet, click the :guilabel:`Create` button, and a blank vehicle form | ||
| will load. Enter the vehicle information in the vehicle form, then click :guilabel:`Save`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this document is going to be forward ported, you can use some adaptive language-- create or new --- if required save, etc. These are small edits that could save you time in the long run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean, but I think it's best to keep the docs for the specific versions, to keep things clear. I do the version specific changes, and I kind of like keeping everything very organized like that. I'll leave this for @StraubCreative to decide since it could go either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@larm-odoo -- Can you explain the copied info?
From #5763
3efb319 to
1abb6c8
Compare
|
Hi @tiku-odoo - I addressed the things I could, and replied to a few things I wasn't 100% on. Thanks for the module explanation- that has been fixed. I didn't see any specific accounting documents I could link to- nothing really mentions vehicles or anything related to it. As for the duplicate looking sections- I see what you mean, but I did check the 2 docs and they are actually different forms but they have a LOT of overlapping entries. But they are accessed form different places and they do have different names for the forms and have different content. If you want to take a second look, it's ready! |
tiku-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Lara- still wondering about the same information in your two fleet PRs-- does one populate the other?
I think we need some clarification on whether it should populate from the model one sets up in #5763 (line 149)-- if not okay, I'm just wondering why we're instructing the user to input the same information twice.
#5763
`Model
- :guilabel:
Seats Number: Enter how many passengers the vehicle can accommodate. - :guilabel:
Doors Number: Enter the number of doors the vehicle has. - :guilabel:
Color: Enter the color of the vehicle. - :guilabel:
Model Year: Enter the year the vehicle was manufactured. - :guilabel:
Trailer Hitch: Check this box if the vehicle has a trailer hitch installed. - Engine
- :guilabel:
Fuel Type: Select the type of fuel the vehicle uses form the drop-down menu. The
options are :guilabel:Diesel, :guilabel:Gasoline, :guilabel:Hybrid Diesel, :guilabel:Hybrid Gasoline, :guilabel:Plug-in Hybrid Diesel, :guilabel:Plug-in Hybrid Gasoline,
:guilabel:CNG, :guilabel:LPG, :guilabel:Hydrogen, or :guilabel:Electric. - :guilabel:
CO2 Emissions: Enter the average carbon dioxide emissions the vehicle produces in
grams per kilometer (g/km). This information is provided by the car manufacturer. - :guilabel:
CO2 Standard: Enter the standard amount of carbon dioxide in grams per kilometer
(g/km) for a similar sized vehicle. - :guilabel:
Transmission: Select the transmission type from the drop-down menu, either
:guilabel:Manualor :guilabel:Automatic. - :guilabel:
Power: If the vehicle is electric or hybrid, enter the power the vehicle uses in
kilowatts (kW). - :guilabel:
Horsepower: Enter the vehicle's horsepower in this field. - :guilabel:
Horsepower Taxation: Enter the amount that is taxed based on the size of the vehicles
engine. This is determined by local taxes and regulations, and varies depending on the location.
It is recommended to check with the accounting department to ensure this value is correct. - :guilabel:
Tax Deduction: This field auto-populates according to the engine specifications, and
cannot be modified. The percentage is based on the localization settings and local tax laws.`
`Model
- :guilabel:`Model Year`: Enter the year the vehicle was manufactured.
- :guilabel:`Transmission`: Select the transmission type from the drop-down menu, either
:guilabel:`Manual` or :guilabel:`Automatic`.
- :guilabel:`Color`: Enter the color of the vehicle.
- :guilabel:`Seats Number`: Enter how many passengers the vehicle can accommodate.
- :guilabel:`Doors Number`: Enter the number of doors the vehicle has.
- :guilabel:`Trailer Hitch`: Check this box if the vehicle has a trailer hitch.
Engine
- :guilabel:
Horsepower: Enter the vehicle's horsepower in this field. - :guilabel:
Power: If the vehicle is electric or hybrid, enter the power the vehicle uses in
kilowatts (kW). - :guilabel:
Fuel Type: Select the type of fuel the vehicle uses form the drop-down menu. The
options are :guilabel:Diesel, :guilabel:Gasoline, :guilabel:Hybrid Diesel, :guilabel:Hybrid Gasoline, :guilabel:Plug-in Hybrid Diesel, :guilabel:Plug-in Hybrid Gasoline,
:guilabel:CNG, :guilabel:LPG, :guilabel:Hydrogen, or :guilabel:Electric. - :guilabel:
CO2 Emissions: Enter the average carbon dioxide emissions the vehicle produces in
grams per kilometer (g/km). This information should be available from the car manufacturer, or
from the dealership the car was purchased from. - :guilabel:
Co2 Standard: Enter the standard amount of carbon dioxide for a similar sized vehicle.
.. image:: new_vehicle/new-vehicle-model.png
:align: center
:alt: The new vehicle form, showing the vehicle tax section.`
1abb6c8 to
c5b24ff
Compare
|
Hi @tiku-odoo and @jero-odoo: This note has been edited so I don't lose any of this info. This doc is referencing an anchor in the configuration doc for Fleet. The PR that must be merged before this one can, is: |
c5b24ff to
2fb4a8c
Compare
jero-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job @larm-odoo . Had a few additional notes, let me know if you have any questions. Thanks!
f9f77fe to
2dd2e28
Compare
2dd2e28 to
75d0422
Compare
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @larm-odoo! This doc looks great, I only have two small corrections that I will push up after this review, please see below. Approving now, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Italicize app names
| Odoo's Fleet app manages all vehicles and the accompanying documentation that comes with vehicle | |
| Odoo's *Fleet* app manages all vehicles and the accompanying documentation that comes with vehicle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| XX.XX format. Repeat this for all entires needed. | |
| XX.XX format. Repeat this for all entries needed. |
Co-authored-by: jero-odoo <104637850+jero-odoo@users.noreply.github.com>
75d0422 to
de5d382
Compare
|
Implemented technical changes in de5d382. @StraubCreative this PR is good to go 👍 and can be FWP all the way up to |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
|
@larm-odoo @StraubCreative staging failed: ci/runbot on 876654e39181f2931dfa2dbc4daf346138c5508c (view more at https://runbot.odoo.com/runbot/build/55789433) |
|
@robodoo retry |
closes #5759 Signed-off-by: Zachary Straub (zst) <zst@odoo.com> Co-authored-by: jero-odoo <104637850+jero-odoo@users.noreply.github.com>
|
@larm-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@larm-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed): |
Adding a new document and section to HR. No fleet documentation currently exists.