[IMP] accounting/l10n_ar: liquidity product direct sales

[rps-odoo]

Link to GDrive images folder: https://drive.google.com/drive/folders/1qWtbGewR3LxDKs21QpMEPhCKEovVyoKx?usp=drive_link

[robodoo]

Pull request status dashboard.

[samueljlieber]

Hi @rps-odoo, nice job getting this PR started! I have a few comments for content clarity, please see below and let me know your thoughts.

I will push up a commit with the changes I have made so far, and will implement your feedback once I hear from you 🙂 thank you!

[samueljlieber]

Thank you @rps-odoo, I implemented your changes in 3a9bef8. This PR should now be ready for review, thanks in advance! 🙏

[samueljlieber]

Thank you for your review @xpl-odoo, I implemented most of your changes in f25a719.

@rps-odoo can you help me address the remaining suggestions?

• Unclear if all document types should be activated or if it depends on the needs of the user
• The toggle don't work for me (17.0 runbot, 17.1 test db, base with the required modules installed, but not the full configuration)
• I don't see those documents, but I didn't fully configure my base runbot (17.0) and test db (17.1) aven though I should have installed all the proper modules. Since you mention installing the AR e-invoicing module is required, you could also say it should be configured? Or not mention the installation at all.
• The meaning is a bit unclear, not sure I got it right

I will update the PR once these ^ have been addressed, thank you!

[samueljlieber]

Thank you @rps-odoo, I implemented your feedback to XPL's comments in 403d55c.

[xpl-odoo]

@robodoo delegate=samueljlieber

[samueljlieber]

@robodoo r+