-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[IMP] Livechat: chatbots 17.0 #8306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @larm-odoo this is ready for you to review. Thank you! |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo - great doc, and I understood how to do everything! I have only suggestions for you to add to the doc, which you can take or leave- nothing is necessary, it's great as-is. Let me know when you want me to take another look.
187de8f to
4e0effe
Compare
|
thanks @larm-odoo this is ready for another look |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
|
@ksc-odoo this is ready for final review. Thanks! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jero-odoo -- just finished my Final Review of this PR. Great Work! I only have a handful of super-minor suggestions that require your attention. But, once you implement the necessary changes, you can feel free to tag this for Tech Review. 👍 Thanks!
8e3acd6 to
a10db18
Compare
|
Hey @samueljlieber this is ready for tech review when you get a chance. Thank you! |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo, nice job on the improvements here, just a couple quick points. Please make sure all doc paths are relative. Thank you!
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
c8ac9e4 to
b80cbb4
Compare
|
Thanks @samueljlieber , ready for another look when you are! |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @jero-odoo, looks good to me! 👍
..
@robodoo r+
Updating Livechat: Chatbots doc for V17, including updating images and content.