Skip to content

Conversation

@brse-odoo
Copy link
Contributor

@brse-odoo brse-odoo commented Apr 1, 2024

This PR is an [ADD] adding a maintenance_calendar doc in Odoo's Maintenance app documentation, specific to 17.0.

Here's what I did:

  • Wrote new maintenance calendar doc for 17.0
  • Added in 17.0 UI-specific screenshots
  • Added new doc to appropriate area of toc tree

Project Task Link

@robodoo
Copy link
Collaborator

robodoo commented Apr 1, 2024

@C3POdoo C3POdoo requested a review from a team April 1, 2024 14:12
@brse-odoo brse-odoo self-assigned this Apr 1, 2024
@brse-odoo
Copy link
Contributor Author

@odoo/maintenance-doc-review This PR is ready for content review when one of you has a chance, thank you!

Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brse-odoo,

Another great doc. Feel free to move it to the next round of review once you take a look at my comments.

Thanks,
hojo

@brse-odoo brse-odoo force-pushed the 17.0-maintenance-add-calendar-doc-brse branch from 9d2c8b3 to 5b3b542 Compare April 3, 2024 14:54
@brse-odoo
Copy link
Contributor Author

Thank you @hojo-odoo for the quick review. Alright @odoo/us-doc-review, this PR is now ready for final content review. Thank you in advance!

@brse-odoo brse-odoo requested a review from a team April 4, 2024 19:15
@samueljlieber samueljlieber added the 5 label Apr 4, 2024
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @brse-odoo -- just finished my Final Review. Once you implement the necessary changes, tag me again for another look. Thanks! 👍

@StraubCreative StraubCreative added the repeat designation for PRs worth a second look label Apr 8, 2024
@brse-odoo brse-odoo force-pushed the 17.0-maintenance-add-calendar-doc-brse branch from 5b3b542 to 74db32d Compare April 9, 2024 17:40
@brse-odoo
Copy link
Contributor Author

hey @brse-odoo -- just finished my Final Review. Once you implement the necessary changes, tag me again for another look. Thanks! 👍

@ksc-odoo Per your request this PR is ready for another look, thank you

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brse-odoo 👍 only one minor adjustment needed. but once that's taken care of, feel free to tag this for Tech Review. Thanks!

@brse-odoo brse-odoo force-pushed the 17.0-maintenance-add-calendar-doc-brse branch from 74db32d to a1e0c01 Compare April 10, 2024 20:21
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brse-odoo
Approving with comments. Please see items below and merge when ready, thanks!
.....
@robodoo delagate=brse-odoo

@brse-odoo brse-odoo force-pushed the 17.0-maintenance-add-calendar-doc-brse branch from a1e0c01 to 1929669 Compare April 10, 2024 20:34
@brse-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Apr 10, 2024

I'm sorry, @brse-odoo: you can't review+.

@StraubCreative
Copy link
Contributor

@robodoo delegate=brse-odoo

@brse-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 repeat designation for PRs worth a second look

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants