Skip to content

Conversation

@ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented May 20, 2024

PROJECT TASK: https://www.odoo.com/web#id=3939026&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

This PR will solely focus on how to create Lead Generation Rules in the Odoo Events application.
Currently, there is only a minor mention of this functionality at the bottom of the outdated track and manage talks doc (which has already been updated; awaiting publication)

@ksc-odoo ksc-odoo added the 5 label May 20, 2024
@ksc-odoo ksc-odoo self-assigned this May 20, 2024
@ksc-odoo ksc-odoo marked this pull request as draft May 20, 2024 21:48
@robodoo
Copy link
Collaborator

robodoo commented May 20, 2024

@ksc-odoo ksc-odoo force-pushed the 17.0-events-adding-lead-generation-rules-ksc branch 2 times, most recently from 5c00b96 to 51bc5d5 Compare May 21, 2024 17:44
@ksc-odoo ksc-odoo marked this pull request as ready for review May 21, 2024 17:44
@C3POdoo C3POdoo requested a review from a team May 21, 2024 17:45
@ksc-odoo
Copy link
Contributor Author

Hey @jero-odoo -- this one is ready for a Peer Review, whenever you get a chance. Thanks!

@ksc-odoo ksc-odoo requested a review from jero-odoo May 21, 2024 17:56
Copy link
Contributor

@jero-odoo jero-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksc-odoo great work on this one, really informative 👍 Most of my notes are optional, so I am approving this for the next round.
One thing to note, in the Sample reul section, there is some switching between pov (sometimes it is written as "the company does this" vs "click here" instructions). That may need a second look just for consistency's sake. Otherwise, looks great! Let me know if you have any questions. Thanks!

@ksc-odoo ksc-odoo force-pushed the 17.0-events-adding-lead-generation-rules-ksc branch from 51bc5d5 to f0f3b47 Compare May 22, 2024 13:28
@ksc-odoo
Copy link
Contributor Author

hey, @jero-odoo 👋 Thank you SO much for all the awesome feedback. I implemented all your suggested changes, and made sure to rework the sample portion at the end to establish a more uniform POV for the reader. That said, I believe this one is now ready for a Final Review, @StraubCreative -- whenever you get a chance. Thanks! 🙏

@ksc-odoo ksc-odoo requested a review from StraubCreative May 22, 2024 13:47
Comment on lines +148 to +150
First, the user would enter a memorable name related to the purpose of the rule in the
:guilabel:`Rule Name` field, like `Social Media Attendees`. Then, select :guilabel:`Per Attendee` in
the :guilabel:`Create` field, and :guilabel:`Attendees are created` in the :guilabel:`When` field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksc-odoo I haven't fully reviewed yet, but this part stuck out to me on quick look.

I'm not sure there's a relevant use case here to create a rule like this since Attendees by Source is more of a reporting filter which can be done right from the Attendees tab in the Events app.

To give readers a working success model, consider covering how we internally set up LGRs for the Events team— the rules we have set up are pretty in-depth and really cover the functionality quite nicely ^^

Please remind me I can show you what I mean, if you like!

@samueljlieber samueljlieber added the cancelled Designation for PRs that are cancelled and closed, the PR should include a closing comment label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 cancelled Designation for PRs that are cancelled and closed, the PR should include a closing comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants