[FIX] side_panel: scroll state issue in chart and pivot side panel#7914
Closed
[FIX] side_panel: scroll state issue in chart and pivot side panel#7914
Conversation
Before this commit: - Commit d04cafc accidentally removed 'overflow-y-auto' from the chart side panel content. - This caused the whole panel to scroll instead of keeping the tab header sticky. After this commit: - Re-added 'overflow-y-auto' on the panel content. - Tabs remain sticky at the top while the content scrolls correctly. Task: 5900595
Before this commit: - When switching tabs in the pivot side panel, the scrollTop value was stored in scrollPosition, but never applied to the DOM. After this commit: - Added a useEffect hook to apply the saved scrollTop whenever the side panel tab changes. Task: 5900595
Collaborator
|
|
Collaborator
|
robodoo r+ |
Collaborator
|
@rmbh-odoo @rrahir because this PR has multiple commits, I need to know how to merge it:
|
Collaborator
|
robodoo rebase-ff |
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2026
Before this commit: - Commit d04cafc accidentally removed 'overflow-y-auto' from the chart side panel content. - This caused the whole panel to scroll instead of keeping the tab header sticky. After this commit: - Re-added 'overflow-y-auto' on the panel content. - Tabs remain sticky at the top while the content scrolls correctly. Task: 5900595 Part-of: #7914 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2026
Before this commit: - When switching tabs in the pivot side panel, the scrollTop value was stored in scrollPosition, but never applied to the DOM. After this commit: - Added a useEffect hook to apply the saved scrollTop whenever the side panel tab changes. closes #7914 Task: 5900595 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes the following fixes:
[FIX] side_panel: restore vertical scrolling for chart side panel tabs
[FIX] side_panel: restore scroll position on pivot tab change
Current behavior before PR:
overflow-y-autofrom the chart side panel content, causing the whole panel to scroll and breaking the sticky tab behavior.Desired behavior:
overflow-y-autoon the chart side panel content so the tab header stays sticky while the content scrolls.Task: 5900595
review checklist