Skip to content

[IMP] locale: add digit grouping for thousands separators#8319

Closed
hokolomopo wants to merge 1 commit intomasterfrom
master-indian-currency-adrm
Closed

[IMP] locale: add digit grouping for thousands separators#8319
hokolomopo wants to merge 1 commit intomasterfrom
master-indian-currency-adrm

Conversation

@hokolomopo
Copy link
Copy Markdown
Contributor

Description

Some locales (eg. India) do not use standard international thousand grouping for large numbers, but group the first 3 numbers, then group the next numbers by 2.

This commit adds the digitGrouping parameter to the locale to handle that behaviour.

Task: 4829185

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 7, 2026

Pull request status dashboard

@hokolomopo hokolomopo force-pushed the master-indian-currency-adrm branch 2 times, most recently from 2388913 to 2a185b3 Compare April 7, 2026 11:38
Comment thread tests/formats/format_helpers.test.ts Outdated
@LucasLefevre
Copy link
Copy Markdown
Collaborator

and small rebase needed, then r+

Some locales (eg. India) do not use standard international thousand
grouping for large numbers, but group the first 3 numbers, then
group the next numbers by 2.

This commit adds the `digitGrouping` parameter to the locale to
handle that behaviour.

Task: 4829185
@hokolomopo hokolomopo force-pushed the master-indian-currency-adrm branch from 2a185b3 to e9f1049 Compare April 16, 2026 06:17
@hokolomopo
Copy link
Copy Markdown
Contributor Author

@LucasLefevre rebased :)

@LucasLefevre
Copy link
Copy Markdown
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 16, 2026
Some locales (eg. India) do not use standard international thousand
grouping for large numbers, but group the first 3 numbers, then
group the next numbers by 2.

This commit adds the `digitGrouping` parameter to the locale to
handle that behaviour.

closes #8319

Task: 4829185
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo added the 19.3 label Apr 16, 2026
@robodoo robodoo closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants