[copy/paste cross spreadsheet] cross version paste should be prevented#8412
Closed
[copy/paste cross spreadsheet] cross version paste should be prevented#8412
Conversation
Collaborator
|
|
Collaborator
Author
|
This PR targets saas-18.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
Author
|
@hokolomopo @VincentSchippefilt ci/runbot failed on this forward-port PR |
When pasting content from the clipboard, we try to paste the spreadsheet content without checking the version of the content, and only fallback if an error was thrown. This is not very resilient, as allowDispatch don't throw, and the model isn't transaction-based, so half of the paste can be applied before an error is thrown. We will now prevent pasting spreadsheet content if the versions do not match, and warn the user. Task: 6095101 X-original-commit: 1ba7513
hokolomopo
force-pushed
the
saas-18.4-18.0-prevent-cross-version-copy-paste-adrm-517125-fw
branch
from
3483fd4 to
c3fab5b
Compare
Collaborator
Author
|
@hokolomopo @VincentSchippefilt this PR has become a normal PR because head updated from 3483fd4 to c3fab5b. It must be merged to be forward-ported further. |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 15, 2026
When pasting content from the clipboard, we try to paste the spreadsheet content without checking the version of the content, and only fallback if an error was thrown. This is not very resilient, as allowDispatch don't throw, and the model isn't transaction-based, so half of the paste can be applied before an error is thrown. We will now prevent pasting spreadsheet content if the versions do not match, and warn the user. closes #8412 Task: 6095101 X-original-commit: 1ba7513 Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com> Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 6095101
review checklist
Forward-Port-Of: #8410
Forward-Port-Of: #8330