Skip to content

[FIX] side_panel: prevent chart picker layout shift on hover#8429

Closed
fw-bot wants to merge 1 commit into19.0from
19.0-18.0-fix-chart-type-picker-layout-on-hover-rmbh-517784-fw
Closed

[FIX] side_panel: prevent chart picker layout shift on hover#8429
fw-bot wants to merge 1 commit into19.0from
19.0-18.0-fix-chart-type-picker-layout-on-hover-rmbh-517784-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Collaborator

@fw-bot fw-bot commented Apr 16, 2026

Description:

Current behavior before PR:

  • Hovering or selecting a chart type was adding a border while reducing padding to compensate for the size change.
  • At non-100% zoom levels, fractional pixel rounding caused inconsistent sizing, leading to layout shifts in the flex container.
  • This resulted in chart icons 'dancing' when moving the cursor between them.

Desired behavior after PR is merged:

  • A transparent border is applied in the default state to reserve space.
  • On hover/selection, only the border color is updated without changing padding.
  • This ensures consistent element dimensions and prevents layout shifts across all zoom levels.

Task: 6095239

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #8307

Before this commit:
- Hovering or selecting a chart type was adding a border while reducing padding
  to compensate for the size change.
- At non-100% zoom levels, fractional pixel rounding caused inconsistent sizing,
  leading to layout shifts in the flex container.
- This resulted in chart icons 'dancing' when moving the cursor between them.

After this commit:
- A transparent border is applied in the default state to reserve space.
- On hover/selection, only the border color is updated without changing padding.
- This ensures consistent element dimensions and prevents layout shifts
  across all zoom levels.

Task: 6095239
X-original-commit: 2d269c3
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Apr 16, 2026

Pull request status dashboard

@fw-bot
Copy link
Copy Markdown
Collaborator Author

fw-bot commented Apr 16, 2026

This PR targets 19.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Copy Markdown
Collaborator Author

fw-bot commented Apr 16, 2026

@rmbh-odoo @hokolomopo the next pull request (#8430) is in conflict. You can merge the chain up to here by saying

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@rmbh-odoo
Copy link
Copy Markdown
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants