[FIX] side_panel: prevent chart picker layout shift on hover#8429
Closed
[FIX] side_panel: prevent chart picker layout shift on hover#8429
Conversation
Before this commit: - Hovering or selecting a chart type was adding a border while reducing padding to compensate for the size change. - At non-100% zoom levels, fractional pixel rounding caused inconsistent sizing, leading to layout shifts in the flex container. - This resulted in chart icons 'dancing' when moving the cursor between them. After this commit: - A transparent border is applied in the default state to reserve space. - On hover/selection, only the border color is updated without changing padding. - This ensures consistent element dimensions and prevents layout shifts across all zoom levels. Task: 6095239 X-original-commit: 2d269c3
Collaborator
Collaborator
Author
|
This PR targets 19.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Collaborator
Author
|
@rmbh-odoo @hokolomopo the next pull request (#8430) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@robodoo r+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Current behavior before PR:
Desired behavior after PR is merged:
Task: 6095239
review checklist
Forward-Port-Of: #8307