Closed
Conversation
Collaborator
|
|
Comment on lines
+6
to
+7
| import { Command } from "../../../../../types/commands"; | ||
| import { UID } from "../../../../../types/misc"; |
Collaborator
There was a problem hiding this comment.
it would better if there were more ../../../../.. because more is better 🙃
rrahir
force-pushed
the
master-fix-autoimport-rar
branch
from
d1e2b8b to
bacabbb
Compare
With the removal of several index files, the typescript engine tends to suggest imports from the root file of the project "src/index.ts" which unfortunately increases the risks of circular dependencies. This revision tweaks the TS server configuration to ignore that file from the autoImport tree. It also removes the current references to that file to prevent future potential circular dependencies issues. Task: 0
rrahir
force-pushed
the
master-fix-autoimport-rar
branch
from
bacabbb to
ab0db1b
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2026
With the removal of several index files, the typescript engine tends to suggest imports from the root file of the project "src/index.ts" which unfortunately increases the risks of circular dependencies. This revision tweaks the TS server configuration to ignore that file from the autoImport tree. It also removes the current references to that file to prevent future potential circular dependencies issues. closes #8522 Task: 0 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
14 tasks
rrahir
added a commit
that referenced
this pull request
Apr 30, 2026
added the alias @src to limit kilometric relative imports. See #8522 (comment) Task: 0
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2026
added the alias @src to limit kilometric relative imports. See #8522 (comment) closes #8523 Task: 0 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the removal of several index files, the typescript engine tends to suggest imports from the root file of the project "src/index.ts" which unfortunately increases the risks of circular dependencies.
This revision tweaks the TS server configuration to ignore that file from the autoImport tree. It also removes the current references to that file to prevent future potential circular dependencies issues.
Task: 0
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist