[IMP] compiler: force validated strings#8694
Closed
LucasLefevre wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
The formula compiler builds JS source by string concatenation and feeds it to `new Function(...)`. Several of those strings came from user input (function names, operator symbols), so any value that slipped past the parser's validation could end up executed as code. This commit introduces a `JsString` branded type plus a `jsStr` tagged-template helper: generated code can only be assembled from values explicitly marked trusted, and untrusted strings must go through `dangerouslyCreateJsStr`, which makes the trust decision auditable. Task: 6185314
LucasLefevre
force-pushed
the
master-compiler-lul
branch
from
efca639 to
50160c6
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 18, 2026
The formula compiler builds JS source by string concatenation and feeds it to `new Function(...)`. Several of those strings came from user input (function names, operator symbols), so any value that slipped past the parser's validation could end up executed as code. This commit introduces a `JsString` branded type plus a `jsStr` tagged-template helper: generated code can only be assembled from values explicitly marked trusted, and untrusted strings must go through `dangerouslyCreateJsStr`, which makes the trust decision auditable. closes #8694 Task: 6185314 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
VincentSchippefilt
pushed a commit
that referenced
this pull request
May 18, 2026
The formula compiler builds JS source by string concatenation and feeds it to `new Function(...)`. Several of those strings came from user input (function names, operator symbols), so any value that slipped past the parser's validation could end up executed as code. This commit introduces a `JsString` branded type plus a `jsStr` tagged-template helper: generated code can only be assembled from values explicitly marked trusted, and untrusted strings must go through `dangerouslyCreateJsStr`, which makes the trust decision auditable. closes #8694 Task: 6185314 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formula compiler builds JS source by string concatenation and feeds it to
new Function(...). Several of those strings came from user input (function names, operator symbols), so any value that slipped past the parser's validation could end up executed as code.This commit introduces a
JsStringbranded type plus ajsStrtagged-template helper:generated code can only be assembled from values explicitly marked trusted, and untrusted strings must go through
dangerouslyCreateJsStr, which makes the trust decision auditable.Task: 6185314
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist