Skip to content

[FIX] pivot: unused pivot detection#8746

Closed
fw-bot wants to merge 2 commits into
masterfrom
master-18.0-fix-unused-pivot-adrm-527731-fw
Closed

[FIX] pivot: unused pivot detection#8746
fw-bot wants to merge 2 commits into
masterfrom
master-18.0-fix-unused-pivot-adrm-527731-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Collaborator

@fw-bot fw-bot commented May 19, 2026

Description:

[FIX] pivot: unused pivot detection with composed formula

If a formula has two pivots (eg. =PIVOT(1) + PIVOT(2)), the
second pivot will not be detected as used.

[FIX] pivot: unused pivot detection with calculated measure

If a pivot has a calculated measure that refers to a second pivot,
the second pivot is not detected as used. This commit fixes that.

Note: the fix does not fix 100% of the issues. A pivot only referenced
in other places (eg. in a CF rule formula) will still not be
detected as used. But checking every other place the pivot can be
referenced is expensive and error-prone. That may be done in master.

Task: 6105894

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #8744
Forward-Port-Of: #8539

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 19, 2026

Pull request status dashboard

@fw-bot
Copy link
Copy Markdown
Collaborator Author

fw-bot commented May 19, 2026

@hokolomopo @LucasLefevre cherrypicking of pull request #8539 failed.

stdout:

Auto-merging src/helpers/pivot/pivot_composer_helpers.ts
Auto-merging src/helpers/pivot/pivot_highlight.ts
Auto-merging src/plugins/ui_core_views/pivot_ui.ts
CONFLICT (content): Merge conflict in src/plugins/ui_core_views/pivot_ui.ts
Auto-merging tests/pivots/pivot_plugin.test.ts
CONFLICT (content): Merge conflict in tests/pivots/pivot_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

:shipit: you can use git-fw to re-do the forward-port for you locally.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

If a pivot has a calculated measure that refers to a second pivot,
the second pivot is not detected as used. This commit fixes that.

Note: the fix does not fix 100% of the issues. A pivot only referenced
in other places (eg. in a CF rule formula) will still not be
detected as used. But checking every other place the pivot can be
referenced is expensive and error-prone. That may be done in master.

Task: 6105894
If a formula has two pivots (eg. `=PIVOT(1) + PIVOT(2)`), the
second pivot will not be detected as used.

Task: 6105894
@hokolomopo hokolomopo force-pushed the master-18.0-fix-unused-pivot-adrm-527731-fw branch from dbcb93e to 7dd4178 Compare May 19, 2026 10:22
@hokolomopo
Copy link
Copy Markdown
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request May 19, 2026
If a pivot has a calculated measure that refers to a second pivot,
the second pivot is not detected as used. This commit fixes that.

Note: the fix does not fix 100% of the issues. A pivot only referenced
in other places (eg. in a CF rule formula) will still not be
detected as used. But checking every other place the pivot can be
referenced is expensive and error-prone. That may be done in master.

Task: 6105894
Part-of: #8746
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
robodoo pushed a commit that referenced this pull request May 19, 2026
If a formula has two pivots (eg. `=PIVOT(1) + PIVOT(2)`), the
second pivot will not be detected as used.

closes #8746

Task: 6105894
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo added the 19.4 label May 19, 2026
@robodoo robodoo closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants