Skip to content

[FIX] Chart type: first chart type change resulted in empty chart#8748

Closed
fw-bot wants to merge 2 commits into
masterfrom
master-saas-19.3-fix-change-chart-type-matho-524268-fw
Closed

[FIX] Chart type: first chart type change resulted in empty chart#8748
fw-bot wants to merge 2 commits into
masterfrom
master-saas-19.3-fix-change-chart-type-matho-524268-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Collaborator

@fw-bot fw-bot commented May 19, 2026

Before this commit:
When changing the chart type for the first time, the dataSource in the chart definition was empty, which caused the chart to be empty.

How to reproduce:

  1. Create a chart
  2. Change the chart type in the side panel from bar to sunburst
  3. The chart becomes empty
  4. Change again the chart type to bar, the chart is not empty
  5. Change again the chart type to sunburst, the chart is not empty

Task: 6197123

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #8578

Before this commit:
When changing the chart type for the first time, the dataSource in the chart definition was empty, which caused the chart to be empty.

How to reproduce:
1. Create a chart
2. Change the chart type in the side panel from bar to sunburst
3. The chart becomes empty
4. Change again the chart type to bar, the chart is not empty
5. Change again the chart type to sunburst, the chart is not empty

Task: 6197123
X-original-commit: 6fc6a5f
Before this commit:
When changing the chart type from sunburst to bar, the label range was not applied.

How to reproduce:
1. Create a hierarchical chart
2. Change the chart type in the side panel from sunburst to bar
3. The label range is empty

Task: 6197123
X-original-commit: a8deb38
@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 19, 2026

Pull request status dashboard

@fw-bot
Copy link
Copy Markdown
Collaborator Author

fw-bot commented May 19, 2026

@matho-odoo @pro-odoo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Copy link
Copy Markdown
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request May 19, 2026
Before this commit:
When changing the chart type for the first time, the dataSource in the chart definition was empty, which caused the chart to be empty.

How to reproduce:
1. Create a chart
2. Change the chart type in the side panel from bar to sunburst
3. The chart becomes empty
4. Change again the chart type to bar, the chart is not empty
5. Change again the chart type to sunburst, the chart is not empty

Task: 6197123
X-original-commit: 6fc6a5f
Part-of: #8748
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
robodoo pushed a commit that referenced this pull request May 19, 2026
Before this commit:
When changing the chart type from sunburst to bar, the label range was not applied.

How to reproduce:
1. Create a hierarchical chart
2. Change the chart type in the side panel from sunburst to bar
3. The label range is empty

closes #8748

Task: 6197123
X-original-commit: a8deb38
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo added the 19.4 label May 19, 2026
@robodoo robodoo closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants