[FIX] range: correctly handle unbounded ranges on row/col changes#8755
Closed
fw-bot wants to merge 1 commit into
Closed
[FIX] range: correctly handle unbounded ranges on row/col changes#8755fw-bot wants to merge 1 commit into
fw-bot wants to merge 1 commit into
Conversation
Collaborator
Collaborator
Author
|
@rmbh-odoo @rrahir cherrypicking of pull request #8533 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
Steps to reproduce: - Create a sheet with 3 rows - Set `A1 = 1`, `A2 = 2`, and `C1 = SUM(A:A)` - Delete row 3 - Add a new row at the bottom - Set `A3 = 6` Issue: - Unbounded ranges (e.g. `A:A`) are not properly updated on row/col changes. The changeType can be incorrectly computed as `NONE` or `MOVE` instead of `RESIZE`, causing formulas to miss newly added cells (e.g. `A3` in `SUM`). Cause: - Incomplete condition handling for unbounded ranges caused inconsistent changeType detection across different scenarios. Fix: - Refine changeType computation for unbounded ranges by covering all edge cases and ensuring correct `RESIZE` behavior when the range should expand. Task: 6167358 X-original-commit: ae0a2d6
4ede2ab to
cdf9215
Compare
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 20, 2026
Steps to reproduce: - Create a sheet with 3 rows - Set `A1 = 1`, `A2 = 2`, and `C1 = SUM(A:A)` - Delete row 3 - Add a new row at the bottom - Set `A3 = 6` Issue: - Unbounded ranges (e.g. `A:A`) are not properly updated on row/col changes. The changeType can be incorrectly computed as `NONE` or `MOVE` instead of `RESIZE`, causing formulas to miss newly added cells (e.g. `A3` in `SUM`). Cause: - Incomplete condition handling for unbounded ranges caused inconsistent changeType detection across different scenarios. Fix: - Refine changeType computation for unbounded ranges by covering all edge cases and ensuring correct `RESIZE` behavior when the range should expand. closes #8755 Task: 6167358 X-original-commit: ae0a2d6 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com> Signed-off-by: Ronakkumar Mukeshbhai Bharadiya (rmbh) <rmbh@odoo.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Steps to reproduce:
A1 = 1,A2 = 2, andC1 = SUM(A:A)A3 = 6Issue:
A:A) are not properly updated on row/col changes.The changeType can be incorrectly computed as
NONEorMOVEinsteadof
RESIZE, causing formulas to miss newly added cells (e.g.A3inSUM).Cause:
changeType detection across different scenarios.
Fix:
cases and ensuring correct
RESIZEbehavior when the range should expand.Task: 6167358
review checklist
Forward-Port-Of: #8533