[PERF] menu: avoid quadratic complexity with proxies#8807
Closed
fw-bot wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
Collaborator
Author
|
@hokolomopo @LucasLefevre cherrypicking of pull request #8794 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
you can use 
In the menu component, we would compute whether to display the icons for each menu item. But to compute that, we need to loop on each menu items, leading to a quadratic complexity. This could have been good enough as menus aren't too large, but the menu items are proxified by Owl, making the loop very slow. Task: 6250318 X-original-commit: 76e93ea
hokolomopo
force-pushed
the
master-17.0-perf-menu-component-adrm-530673-fw
branch
from
e66b39c to
37b5871
Compare
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 28, 2026
In the menu component, we would compute whether to display the icons for each menu item. But to compute that, we need to loop on each menu items, leading to a quadratic complexity. This could have been good enough as menus aren't too large, but the menu items are proxified by Owl, making the loop very slow. closes #8807 Task: 6250318 X-original-commit: 76e93ea Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the menu component, we would compute whether to display the icons for each menu item. But to compute that, we need to loop on each menu items, leading to a quadratic complexity.
This could have been good enough as menus aren't too large, but the menu items are proxified by Owl, making the loop very slow.
Task: 6250318
review checklist
Forward-Port-Of: #8805
Forward-Port-Of: #8794