[FW][IMP] l10n_ph: BIR 2307 fix #201696
Closed
[FW][IMP] l10n_ph: BIR 2307 fix #201696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@vin-odoo @qdp-odoo cherrypicking of pull request #201489 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
vin-odoo
force-pushed
the
saas-17.4-16.0-l10n_ph_2307_tax_fix-vin-422642-fw
branch
from
2a49000 to
36f9b50
Compare
The export is completely wrong when it comes to multiple taxes affecting each others. It would recompute the withholding taxes one by one based on the price subtotal instead of taking into account all other taxes as you would expect. task-4641930 X-original-commit: 352ae03
vin-odoo
force-pushed
the
saas-17.4-16.0-l10n_ph_2307_tax_fix-vin-422642-fw
branch
from
36f9b50 to
0804cf6
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 14, 2025
The export is completely wrong when it comes to multiple taxes affecting each others. It would recompute the withholding taxes one by one based on the price subtotal instead of taking into account all other taxes as you would expect. task-4641930 closes #201696 X-original-commit: 352ae03 Signed-off-by: Quentin De Paoli (qdp) <qdp@odoo.com> Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export is completely wrong when
it comes to multiple taxes affecting
each others.
It would recompute the withholding
taxes one by one based on the price
subtotal instead of taking into account
all other taxes as you would expect.
task-4641930
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #201614
Forward-Port-Of: #201489