Skip to content

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 14, 2025

The export is completely wrong when
it comes to multiple taxes affecting
each others.

It would recompute the withholding
taxes one by one based on the price
subtotal instead of taking into account
all other taxes as you would expect.

task-4641930


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #201696
Forward-Port-Of: #201489

@robodoo
Copy link
Contributor

robodoo commented Mar 14, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 14, 2025

@vin-odoo @qdp-odoo cherrypicking of pull request #201489 failed.

stdout:

Auto-merging addons/l10n_ph/tests/test_bir_2307_generation.py
Auto-merging addons/l10n_ph/wizard/generate_2307_wizard.py
CONFLICT (content): Merge conflict in addons/l10n_ph/wizard/generate_2307_wizard.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Mar 14, 2025
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 14, 2025
The export is completely wrong when
it comes to multiple taxes affecting
each others.

It would recompute the withholding
taxes one by one based on the price
subtotal instead of taking into account
all other taxes as you would expect.

task-4641930

X-original-commit: 1014d41
@vin-odoo vin-odoo force-pushed the 18.0-16.0-l10n_ph_2307_tax_fix-vin-422800-fw branch from ba5936a to c7cf2c1 Compare March 15, 2025 02:20
@vin-odoo
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in 5d6e21d Mar 15, 2025
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 17, 2025
The export is completely wrong when
it comes to multiple taxes affecting
each others.

It would recompute the withholding
taxes one by one based on the price
subtotal instead of taking into account
all other taxes as you would expect.

task-4641930

closes odoo/odoo#201809

X-original-commit: 1014d412a7f2b0f46e2c082181a286696defe1eb
Signed-off-by: Quentin De Paoli (qdp) <qdp@odoo.com>
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
@fw-bot fw-bot deleted the 18.0-16.0-l10n_ph_2307_tax_fix-vin-422800-fw branch March 22, 2025 06:20
omar-sherif9992 pushed a commit to odoo-dev/odoo that referenced this pull request Mar 26, 2025
The export is completely wrong when
it comes to multiple taxes affecting
each others.

It would recompute the withholding
taxes one by one based on the price
subtotal instead of taking into account
all other taxes as you would expect.

task-4641930

closes odoo#201809

X-original-commit: 1014d41
Signed-off-by: Quentin De Paoli (qdp) <qdp@odoo.com>
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants