Skip to content

Conversation

phenix-factory
Copy link
Contributor

@phenix-factory phenix-factory commented Aug 9, 2023

Before this commit, message actions were all defined in template
of Message component. It's good when there are few actions and
the ordering of actions is always the same, but there are now
many actions and we want to order these actions depending on context.

This commit fixes the issue by introducing a special registry to add
message actions. This registry is quite similar to thread actions:
each item define conditions to be shown, behaviour on click, and
their sequence which can depend on the context where the message is
being viewed.

In addition to this message action registry, this commit also
reorder message actions in inbox as follow:

  1. Quick actions:
  • Add a Reaction
  • Mark as To do
  • Mark as Read
  1. More menu:
  • View reactions
  • Reply
  • Unfollow
  • Edit
  • Delete

Task-3458086

@robodoo
Copy link
Contributor

robodoo commented Aug 9, 2023

Pull request status dashboard

@phenix-factory phenix-factory force-pushed the master-mail-reorder-inbox-actions-did branch from 817c84a to baaa14d Compare August 9, 2023 13:56
@C3POdoo C3POdoo added the RD research & development, internal work label Aug 9, 2023
@phenix-factory phenix-factory marked this pull request as ready for review August 9, 2023 14:00
@C3POdoo C3POdoo requested review from a team August 9, 2023 14:15
@alexkuhn
Copy link
Contributor

I would introduce message_actions with a similar architecture to thread_actions, so that it's much easier to adapt for new specs

@phenix-factory phenix-factory force-pushed the master-mail-reorder-inbox-actions-did branch 3 times, most recently from d0fac7d to a3cbbfe Compare August 24, 2023 12:05
@phenix-factory phenix-factory marked this pull request as draft August 24, 2023 12:25
@phenix-factory phenix-factory force-pushed the master-mail-reorder-inbox-actions-did branch 16 times, most recently from d33b6b9 to 7122d09 Compare August 29, 2023 12:19
@phenix-factory phenix-factory marked this pull request as ready for review August 29, 2023 12:23
@phenix-factory phenix-factory force-pushed the master-mail-reorder-inbox-actions-did branch 2 times, most recently from 92182ac to c1a311c Compare August 29, 2023 12:28
robodoo pushed a commit that referenced this pull request Jan 22, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: #131426

closes #194643

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
adhoc-cicd-bot pushed a commit to adhoc-cicd/odoo-odoo that referenced this pull request Jan 24, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

closes odoo#194643

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
adhoc-cicd-bot pushed a commit to adhoc-cicd/odoo-odoo that referenced this pull request Jan 25, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

closes odoo#194643

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
alexkuhn pushed a commit to odoo-dev/odoo that referenced this pull request Jan 25, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

X-original-commit: 85bc95e
robodoo pushed a commit that referenced this pull request Jan 25, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: #131426

closes #194751

X-original-commit: 85bc95e
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jan 25, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

X-original-commit: 86ec467
robodoo pushed a commit that referenced this pull request Jan 25, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: #131426

closes #195183

X-original-commit: 86ec467
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
alexkuhn pushed a commit to odoo-dev/odoo that referenced this pull request Jan 25, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

X-original-commit: 86ec467
robodoo pushed a commit that referenced this pull request Jan 26, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: #131426

closes #195185

X-original-commit: 86ec467
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
alexkuhn pushed a commit to odoo-dev/odoo that referenced this pull request Jan 27, 2025
Currently, Odoo only renders the custom component for quick actions. However, the remaining actions, rendered as DropdownItem, do not invoke the custom component.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

X-original-commit: f059d78
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jan 27, 2025
Currently, Odoo only renders the custom component for quick actions. However, the remaining actions, rendered as DropdownItem, do not invoke the custom component.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

X-original-commit: ce537b6
robodoo pushed a commit that referenced this pull request Jan 27, 2025
Currently, Odoo only renders the custom component for quick actions. However, the remaining actions, rendered as DropdownItem, do not invoke the custom component.
This commit ensures that the rendering is consistent in both cases.

Complementary to: #131426

closes #195189

X-original-commit: f059d78
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Jan 27, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo/odoo#131426

closes odoo/odoo#195185

X-original-commit: 86ec467457499e76a9081660d824b8755067b931
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
robodoo pushed a commit that referenced this pull request Jan 27, 2025
Currently, Odoo only renders the custom component for quick actions. However, the remaining actions, rendered as DropdownItem, do not invoke the custom component.
This commit ensures that the rendering is consistent in both cases.

Complementary to: #131426

closes #195205

X-original-commit: ce537b6
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
adhoc-cicd-bot pushed a commit to adhoc-cicd/odoo-odoo that referenced this pull request Jan 29, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

closes odoo#195185

X-original-commit: 86ec467
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
adhoc-cicd-bot pushed a commit to adhoc-cicd/odoo-odoo that referenced this pull request Jan 29, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

closes odoo#195185

X-original-commit: 86ec467
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
StephaneMangin pushed a commit to camptocamp/odoo that referenced this pull request Feb 6, 2025
Currently, Odoo only renders the callComponent for quick actions (2 or 3 actions). However, the remaining actions, rendered as DropdownItem, do not invoke the callComponent.
This commit ensures that the rendering is consistent in both cases.

Complementary to: odoo#131426

closes odoo#195185

X-original-commit: 86ec467
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

16.5 RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants