[9.0][FIX] Fixed inconsistent UoM domain in Quotations/Order #3 #13546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create test
I agree to the license terms
|
CLA try #2 |
…m would be changed in the onchange function called by a changed product_id. This onchange function would change the domain on product_uom for ALL lines in the order. Also, when editing the order, the product_uom would have no domain. The user would experience an inconsistent UI compared to when he created the lines. To solve these issues: 1) I Added a relative field for the category_id of product_uom, and stored it in the database. 2) I added this relative field to the view (invisible=1), and used it in the default domain for product_uom.
[9.0][BUG] Fixed inconsistent UoM domain in Quotations/Order
nicknomo
changed the title
nicknomo
changed the title
mart-e
requested changes
Dec 13, 2016
| product_uom_qty = fields.Float(string='Quantity', digits=dp.get_precision('Product Unit of Measure'), required=True, default=1.0) | ||
| product_uom = fields.Many2one('product.uom', string='Unit of Measure', required=True) | ||
| #We've added a related field to store the category of the UoM for this line. We use this as a default domain in the view. | ||
| relcatid = fields.Many2one(related='product_uom.category_id', store=True) |
There was a problem hiding this comment.
not compatible with stable policy
|
Hello, We can not add new fields in stable versions. Please either resubmit for the master branch or adapt your code to avoid the new field. |
|
Dear @nicknomo, Thank you for your contribution but the version 9.0 is no longer supported. We apology if we could not look at your request in time. This is an automated message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
The product_uom field's domain in sale.order.line would be inconsistent and improper in several situations.
Current behavior before PR:
When adding a line to a quotation/order, the domain of the product_uom would be changed in the onchange function called by a changed product_id. This onchange function would change the domain on product_uom for ALL lines in the order.
Also, when editing the order, the product_uom would have no domain. The user would experience an inconsistent UI compared to when they created the lines.
Desired behavior after PR is merged:
The category for the product_uom's domain will always be properly defined. Each line will have an independent domain, and it will restrict the product_uom selection so that it can only be changed to UoM's in the same category as the existing UoM.
To solve these issues:
I Added a relative field for the category_id of product_uom, and stored it in the database.
I added this relative field to the view (invisible=1), and used it in the default domain for product_uom.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr