[FIX] web: make export consistent for int/float/monetary field #178214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
requested review from
a team,
BastienFafchamps,
HydrionBurst,
Julien00859,
kebeclibre and
kmagusiak
and removed request for
a team
ryv-odoo
force-pushed
the
master-fix-monetary-export-ryv
branch
3 times, most recently
from
adb5f76 to
df53d5e
Compare
kmagusiak
approved these changes
Aug 29, 2024
ryv-odoo
force-pushed
the
master-fix-monetary-export-ryv
branch
5 times, most recently
from
2f8e2bb to
53c39a7
Compare
ryv-odoo
changed the title
ryv-odoo
force-pushed
the
master-fix-monetary-export-ryv
branch
3 times, most recently
from
7b14f85 to
8275ebb
Compare
ryv-odoo
force-pushed
the
master-fix-monetary-export-ryv
branch
from
8275ebb to
0e1cbbe
Compare
kmagusiak
approved these changes
Sep 4, 2024
The float/monetary/int can be in an incorrect format depending of the other columns format. Then int was sometimes show as float (1.00 by example). Same situation for monetary, that was often export as an integer. It was because we changed the `base_style` instead of having one by type of field. Fix these kinds of inconsistency. task-4129701
In the previous fix, we need the field type during the export (or
it raises a KeyError by `field['type'] == ...`). The field information
comes from the web/export/get_fields route and can also come
from the web/export/namelist route when you use a export template.
But for web/export/namelist, we only send back field id and string
(label) information. Then we try to export we got a Traceback because
there is no field type.
One solution is to make the previous fix robust by using
`field.get('type')`, but it hides the issue and make the previous fix
and previous other usage of field type useless. Then fix
web/export/namelist to return the field type information.
ryv-odoo
force-pushed
the
master-fix-monetary-export-ryv
branch
from
0e1cbbe to
22608af
Compare
|
@robodoo r+ |
|
@ryv-odoo because this PR has multiple commits, I need to know how to merge it:
|
|
@robodoo rebase-merge |
|
Merge method set to rebase and merge, using the PR as merge commit message. |
robodoo
pushed a commit
that referenced
this pull request
Sep 14, 2024
The float/monetary/int can be in an incorrect format depending of the other columns format. Then int was sometimes show as float (1.00 by example). Same situation for monetary, that was often export as an integer. It was because we changed the `base_style` instead of having one by type of field. Fix these kinds of inconsistency. task-4129701 Part-of: #178214 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 14, 2024
In the previous fix, we need the field type during the export (or
it raises a KeyError by `field['type'] == ...`). The field information
comes from the web/export/get_fields route and can also come
from the web/export/namelist route when you use a export template.
But for web/export/namelist, we only send back field id and string
(label) information. Then we try to export we got a Traceback because
there is no field type.
One solution is to make the previous fix robust by using
`field.get('type')`, but it hides the issue and make the previous fix
and previous other usage of field type useless. Then fix
web/export/namelist to return the field type information.
Part-of: #178214
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
robodoo
added a commit
that referenced
this pull request
Sep 14, 2024
The float/monetary/int can be in an incorrect format depending of the other columns format. Then int was sometimes show as float (1.00 by example). Same situation for monetary, that was often export as an integer. It was because we changed the `base_style` instead of having one by type of field. Fix these kinds of inconsistency. task-4129701 closes #178214 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 14, 2024
The float/monetary/int can be in an incorrect format depending of the other columns format. Then int was sometimes show as float (1.00 by example). Same situation for monetary, that was often export as an integer. It was because we changed the `base_style` instead of having one by type of field. Fix these kinds of inconsistency. task-4129701 Part-of: #178214 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Sep 14, 2024
In the previous fix, we need the field type during the export (or
it raises a KeyError by `field['type'] == ...`). The field information
comes from the web/export/get_fields route and can also come
from the web/export/namelist route when you use a export template.
But for web/export/namelist, we only send back field id and string
(label) information. Then we try to export we got a Traceback because
there is no field type.
One solution is to make the previous fix robust by using
`field.get('type')`, but it hides the issue and make the previous fix
and previous other usage of field type useless. Then fix
web/export/namelist to return the field type information.
Part-of: #178214
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
robodoo
added a commit
that referenced
this pull request
Sep 14, 2024
The float/monetary/int can be in an incorrect format depending of the other columns format. Then int was sometimes show as float (1.00 by example). Same situation for monetary, that was often export as an integer. It was because we changed the `base_style` instead of having one by type of field. Fix these kinds of inconsistency. task-4129701 closes #178214 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The float/monetary/int can be in an incorrect format depending of the
other columns format. Then int was sometimes show as float (1.00 by
example). Same situation for monetary, that was often export as an
integer.
It was because we changed the
base_styleinstead of having one by typeof field.
Fix these kinds of inconsistency.
task-4129701