[IMP] various: improve user error wording #178821

ppr-odoo · 2024-09-02T13:05:06Z

Before this commit error messages in odoo are boring and not much attractive to user. Those were like odoo is preventing them from doing something user want to do.

In this commit, we have modified the message to be a more friendly and humorous tone, making it less tedious and more enjoyable. It aims to enhance the user experience and ensure that interactions with any application are both pleasant and informative. As a result, the messages have been clear, short, easy to understand and informative.

Task link
task-3422664

robodoo · 2024-09-02T13:05:13Z

addons/account/models/account_move.py

fpodoo · 2025-02-25T08:14:12Z

addons/account/tests/test_account_move_entry.py

        honest_move.action_post()

-        with self.assertRaisesRegex(UserError, 'not balanced'), self.env.cr.savepoint():
+        with self.assertRaisesRegex(UserError, 'unbalanced'), self.env.cr.savepoint():


revert this; not balanced seems better.

addons/account/tests/test_account_move_entry.py

addons/account/wizard/account_automatic_entry_wizard.py

fpodoo · 2025-02-25T08:18:19Z

addons/analytic/models/analytic_account.py

                '!', ('company_id', 'child_of', company.id),
            ], limit=1):
-                raise UserError(_("You can't set a different company on your analytic account since there are some analytic items linked to it."))
+                raise UserError(_("No company-switching allowed for your analytic account while there are some linked analytic items around! It's a recipe for an analytical disaster!"))


Replace by "You can't change the company of an analytic account having analytic items around! It's a recipe for an analytical disaster!""

addons/crm/models/crm_lead.py

addons/hr_contract/models/hr_contract.py

fpodoo · 2025-02-25T08:24:33Z

addons/phone_validation/tools/phone_validation.py

                    raise UserError(_('Impossible number %s: too many digits.', number))
            else:
-                raise UserError(_('Impossible number %s: probably invalid number of digits.', number))
+                raise UserError(_("The format of the number %s is incorrect unless you're dialing aliens! Let's fix it.", number))


Replace by "The phone number %s is incorrect! Let's fix it - you are not dialing aliens."

ppr-odoo · 2025-03-02T09:30:38Z

Hello @ticodoo @william-andre @dylankiss

I have incorporated the suggestions discussed with Jihane. Kindly let me know if anything is missing or if you have any additional suggestions

cc @xavierbol

william-andre

Nothing important left for the accounting scope

addons/account/models/account_payment_term.py

ticodoo

Please make sure you correctly apply all of my grammar change suggestions. I don't have time to review all of the strings again.

ticodoo · 2025-03-03T08:13:46Z

addons/account/models/account_move.py

missing space + grammar issue + maybe better wording?:

Suggested change

"The journal entry is not balanced,"

"with %(debit_total)s on the debit side and %(credit_total)s on the credit side. We need some equilibrium here!\n\n"

"The journal entry is not balanced, "

"with %(debit_total)s on the debit side and %(credit_total)s on the credit side, there needs to be an equilibrium!\n\n"

@ticodoo Maybe another suggestion?

Suggested change

"The journal entry is not balanced,"

"with %(debit_total)s on the debit side and %(credit_total)s on the credit side. We need some equilibrium here!\n\n"

"The journal entry is not balanced. "

"With %(debit_total)s on the debit side and %(credit_total)s on the credit side, we've disrupted the equilibrium!\n\n"

"we've disrupted the equilibrium" sounds a bit weird here. The comma/period change is fine. Doesn't really make a difference

ticodoo · 2025-03-03T08:35:05Z

addons/account/models/account_move.py

We can't post thin air! doesn't work. There's no way to fit in "air" into this sentence without it sounding weird/forced. It needs to be a completely different sentence.

Here's an AI generated option that sounds much better: "Even magicians can't post nothing!"

ticodoo · 2025-03-03T08:39:04Z

addons/account/wizard/account_automatic_entry_wizard.py

you applied my suggestion incorrectly. Same comment for line below

Suggested change

raise UserError(_("Oops! You can't change the period/account for posted entries! Only the draft ones are up for such an adventure like that!"))

raise UserError(_("Oops! You can't change the period/account for posted entries! Only the draft ones are up for an adventure like that!"))

ticodoo · 2025-03-03T14:42:40Z

addons/analytic/models/analytic_account.py

Incorrect grammar:

Suggested change

raise UserError(_("You can't change the company of an analytic account having analytic items around! It's a recipe for an analytical disaster!"))

raise UserError(_("You can't change the company of an analytic account that has analytic items lying around! It's a recipe for an analytical disaster!"))

That being said, not sure if "lying around" is what the original change was going for. If not, then the more straightforward:

Suggested change

raise UserError(_("You can't change the company of an analytic account having analytic items around! It's a recipe for an analytical disaster!"))

raise UserError(_("You can't change the company of an analytic account that already has analytic items! It's a recipe for an analytical disaster!"))

is better

ticodoo · 2025-03-03T14:55:35Z

addons/hr_expense/models/hr_expense.py

This is correct, but will be terrible in certain countries/cultures where smiling isn't as common as it is in the US/Belgium.

ticodoo · 2025-03-03T18:00:59Z

addons/web/static/src/views/list/list_confirmation_dialog.xml

This "Update All" button wording is a bit confusing. You're not updating all the records, only the ones you have selected. So maybe this is better?

Suggested change

Update All

Update

ticodoo · 2025-03-03T18:05:29Z

addons/website/static/src/components/dialog/page_properties.xml

Suggested change

 1">Ready to make those web pages disappear into thin air? Are you sure?\n It will be gone forever!\n

But before deleting them, make sure you update all links referring to them. That way, your customers won't bump into the not-so-famous 404 error page.



Ready to make this web page disappear into thin air? Are you sure?\n It will be gone forever!\n

But before deleting it, make sure you update all links referring to it. That way, your customers won't bump into the not-so-famous 404 error page.

 1">Ready to make these web pages disappear into thin air? Are you sure?\n They will be gone forever!\n

But before deleting, make sure you update all links referring to them. That way, your customers won't bump into the not-so-famous 404 error page.



Ready to make this web page disappear into thin air? Are you sure?\n It will be gone forever!\n

But before deleting, make sure you update all links referring to it. That way, your customers won't bump into the not-so-famous 404 error page.

ticodoo · 2025-03-03T18:08:47Z

addons/website_slides_survey/models/survey_survey.py

Suggested change

'Uh-oh! You can’t delete a survey used as a Course Certification! Otherwise, students might think diplomas just grow on trees.\n'

'The courses that need it are:\n%s',

'Uh-oh! You can’t delete surveys used as a Course Certification! Otherwise, students might think diplomas just grow on trees.\n'

'The courses that need them are:\n%s',

ticodoo · 2025-03-03T18:10:00Z

odoo/orm/models.py

Suggested change

"Our troublemaker is: %(model_display)s\n"

"Blame the following constraint: %(field_display)s\n"

"How about archiving the record instead?",

"The troublemaker is: %(model_display)s\n"

"Thanks to the following constraint: %(field_display)s\n"

"How about archiving the record instead?",

ticodoo · 2025-03-03T18:11:41Z

odoo/orm/models.py

Suggested change

lines.append(_("To avoid a mess, no company crossover allowed!"))

lines.append(_("To avoid a mess, no company crossover is allowed!"))

william-andre · 2025-03-03T18:14:56Z

Please make sure you correctly apply all of my grammar change suggestions. I don't have time to review all of the strings again.

Shouldn't this kind of tasks be done by native (probably from the US) speakers...?

dylankiss

Some suggestions, but also some important functional issues. Please check them carefully 🙏

dylankiss · 2025-03-03T19:52:29Z

addons/account/models/account_move.py

Why are you directly raising a UserError here and below instead of appending it to the list of errors to show in the end? Because all the rest is left the same 🤔

dylankiss · 2025-03-03T20:25:49Z

addons/account/wizard/account_automatic_entry_wizard.py

Suggested change

raise UserError(_("Oops! You can't change the period/account for posted entries! Only the draft ones are up for such an adventure like that!"))

raise UserError(_("Oops! You can only change the period or account for posted entries! Other ones aren't up for an adventure like that!"))

Oops, seems like you totally changed the meaning of this message. The original message says that you can only change the period or account for posted journal items, not for other ones! Please correct this.

dylankiss · 2025-03-03T20:32:16Z

addons/account/models/account_move.py

@ticodoo Maybe another suggestion?

Suggested change

"The journal entry is not balanced,"

"with %(debit_total)s on the debit side and %(credit_total)s on the credit side. We need some equilibrium here!\n\n"

"The journal entry is not balanced. "

"With %(debit_total)s on the debit side and %(credit_total)s on the credit side, we've disrupted the equilibrium!\n\n"

dylankiss · 2025-03-03T20:32:51Z

addons/account/models/account_move.py

Same question as above. Why raising here already?

dylankiss · 2025-03-03T20:36:06Z

addons/account/models/account_move.py

Suggested change

raise ValidationError(_("Once a document is posted, its type is set in stone and you can't change it anymore."))

raise ValidationError(_("Once a document has been posted once, its type is set in stone and you can't change it anymore."))

You lost some nuance in the message. The type can't be changed anymore if the entry has ever been posted before. So even if they reset it to draft afterwards, it would still remain immutable.

dylankiss · 2025-03-03T20:48:55Z

addons/hr_holidays/models/hr_leave.py

Suggested change

raise UserError(error_message % state_description_values.get(self[:1].state))

raise UserError("You can't delete a time off request that is in %(leave_state)s state.", leave_state=state_description_values.get(self[:1].state))

dylankiss · 2025-03-03T20:49:45Z

addons/hr_holidays/models/hr_leave.py

@ticodoo Maybe even this?

Suggested change

raise UserError(_("You can't delete a time off which is in the past"))

raise UserError(_("You can't delete a time off request that is in the past."))

dylankiss · 2025-03-03T20:51:58Z

addons/hr_holidays/models/hr_leave.py

Suggested change

raise UserError(error_message % (state_description_values.get(holiday.state),))

raise UserError("You can't delete a time off request that is in %(leave_state)s state.", leave_state=state_description_values.get(holiday.state))

dylankiss · 2025-03-03T21:01:14Z

addons/lunch/models/lunch_order.py

You might want to validate if this is only for food, and not for drinks too. Maybe this is better? @ticodoo

Suggested change

raise ValidationError(_('Oh no! You don’t have enough money in your wallet to order that food! Contact your lunch manager to add some money in your wallet.'))

raise ValidationError(_('Oh no! You don’t have enough money in your wallet to order your selected lunch! Contact your lunch manager to add some money to your wallet.'))

It is also for drinks. If we want to keep it generic, we can make it your selected items, in case someone is using the lunch app...for other non-lunch meals/things.

dylankiss · 2025-03-03T22:08:37Z

addons/web/static/src/views/list/list_confirmation_dialog.xml

Uhh, this line looks extremely awkward in context

Totally agree. I don't really understand the purpose in this context 🤔

fpodoo · 2025-03-10T15:40:40Z

@robodoo r+

fpodoo · 2025-03-10T15:40:50Z

@robodoo r+

robodoo · 2025-03-10T15:40:53Z

This PR is already reviewed, reviewing it again is useless.

robodoo · 2025-03-10T16:00:07Z

@ppr-odoo @fpodoo linked pull request(s) odoo/enterprise#69284 not ready. Linked PRs are not staged until all of them are ready.

xavierbol · 2025-05-05T10:10:43Z

Hello @ppr-odoo

Can you rebase your branch?

We will surely merge that this week.

xavierbol · 2025-05-05T10:12:52Z

addons/web/static/src/views/list/list_confirmation_dialog.js

Cannot we directly write those messages in the template as before? 🤔

You can check the result in the pot file.

Having it in template with a t-esc in the middle makes separate translation phrases for each part such as "are valid for this update." (alone by itself) which makes no sense for translators.

Not only is it hard to understand, but different languages need the counter to be at different places in the phrase.

It's important to never concatenate parts of translations together in code (or in template) as those usually only work in English.

Ah okay. 🙂

Thanks for the explanation! 🙂

Before this commit error messages in odoo are boring and not much attractive to user. Those were like odoo is preventing them from doing something user want to do. In this commit, we have modified the message to be a more friendly and humorous tone, making it less tedious and more enjoyable. It aims to enhance the user experience and ensure that interactions with any application are both pleasant and informative. As a result, the messages have been clear, short, easy to understand and informative. task-3422664 Co-authored-by: Kartik Chavda <kcv@odoo.com> Co-authored-by: Kamlesh Pathekar (kpt) <kpt@odoo.com> Co-authored-by: Aman Patel (ampa) <ampa@odoo.com>

xavierbol

robodoo r+

Before this commit error messages in odoo are boring and not much attractive to user. Those were like odoo is preventing them from doing something user want to do. In this commit, we have modified the message to be a more friendly and humorous tone, making it less tedious and more enjoyable. It aims to enhance the user experience and ensure that interactions with any application are both pleasant and informative. As a result, the messages have been clear, short, easy to understand and informative. task-3422664 closes #178821 Related: odoo/enterprise#69284 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com> Co-authored-by: Kartik Chavda <kcv@odoo.com> Co-authored-by: Kamlesh Pathekar (kpt) <kpt@odoo.com> Co-authored-by: Aman Patel (ampa) <ampa@odoo.com>

ppr-odoo mentioned this pull request Sep 2, 2024

[IMP] various: improve user error wording #141193

Closed

C3POdoo added the RD research & development, internal work label Sep 2, 2024

fpodoo requested changes Feb 25, 2025

View reviewed changes

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch from 8f8dbf4 to f073493 Compare February 26, 2025 07:24

xavierbol marked this pull request as ready for review February 26, 2025 12:08

C3POdoo requested review from a team, aab-odoo, casp-odoo, kebeclibre, kmagusiak, ryv-odoo and svs-odoo and removed request for a team February 26, 2025 12:10

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch 2 times, most recently from 407ecb6 to cfafbf7 Compare March 2, 2025 09:23

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch from cfafbf7 to f332521 Compare March 3, 2025 08:59

william-andre reviewed Mar 3, 2025

View reviewed changes

addons/account/models/account_payment_term.py Outdated Show resolved Hide resolved

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch 2 times, most recently from 1a0736c to 9576c89 Compare March 3, 2025 13:17

ticodoo reviewed Mar 3, 2025

View reviewed changes

dylankiss requested changes Mar 3, 2025

View reviewed changes

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch from 9576c89 to d3e3ead Compare March 7, 2025 11:25

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch 2 times, most recently from 87cb46f to 8a24aec Compare March 17, 2025 08:02

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch 3 times, most recently from e3119e1 to c40d7f7 Compare April 24, 2025 05:30

xavierbol reviewed May 5, 2025

View reviewed changes

ppr-odoo force-pushed the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch from c40d7f7 to fbede01 Compare May 8, 2025 13:40

xavierbol reviewed May 9, 2025

View reviewed changes

robodoo added the 18.4 label May 11, 2025

robodoo temporarily deployed to merge May 11, 2025 02:35 Inactive

robodoo closed this May 11, 2025

fw-bot deleted the master-user-error-fine-tuning-ux-kcv-kpt-ppr branch May 18, 2025 05:47

-        <p t-if="props.resIds.length > 1">Ready to make those web pages disappear into thin air? Are you sure?\n It will be gone forever!\n
-            <span class="text-warning">But before deleting them, make sure you update all links referring to them. That way, your customers won't bump into the not-so-famous 404 error page.</span>
-        </p>
-        <p t-else="">Ready to make this web page disappear into thin air? Are you sure?\n It will be gone forever!\n
-            <span class="text-warning">But before deleting it, make sure you update all links referring to it. That way, your customers won't bump into the not-so-famous 404 error page.</span>
+        <p t-if="props.resIds.length > 1">Ready to make these web pages disappear into thin air? Are you sure?\n They will be gone forever!\n
+            <span class="text-warning">But before deleting, make sure you update all links referring to them. That way, your customers won't bump into the not-so-famous 404 error page.</span>
+        </p>
+        <p t-else="">Ready to make this web page disappear into thin air? Are you sure?\n It will be gone forever!\n
+            <span class="text-warning">But before deleting, make sure you update all links referring to it. That way, your customers won't bump into the not-so-famous 404 error page.</span>

-                    "The journal entry is not balanced,"
-                    "with %(debit_total)s on the debit side and %(credit_total)s on the credit side. We need some equilibrium here!\n\n"
+                    "The journal entry is not balanced, "
+                    "with %(debit_total)s on the debit side and %(credit_total)s on the credit side, there needs to be an equilibrium!\n\n"

	raise UserError(_("Oops! You can't change the period/account for posted entries! Only the draft ones are up for such an adventure like that!"))
	raise UserError(_("Oops! You can't change the period/account for posted entries! Only the draft ones are up for an adventure like that!"))

	raise UserError(_("You can't change the company of an analytic account having analytic items around! It's a recipe for an analytical disaster!"))
	raise UserError(_("You can't change the company of an analytic account that has analytic items lying around! It's a recipe for an analytical disaster!"))

-                'Uh-oh! You can’t delete a survey used as a Course Certification! Otherwise, students might think diplomas just grow on trees.\n'
-                'The courses that need it are:\n%s',
+                'Uh-oh! You can’t delete surveys used as a Course Certification! Otherwise, students might think diplomas just grow on trees.\n'
+                'The courses that need them are:\n%s',

-                "Our troublemaker is: %(model_display)s\n"
-                "Blame the following constraint: %(field_display)s\n"
-                "How about archiving the record instead?",
+                "The troublemaker is: %(model_display)s\n"
+                "Thanks to the following constraint: %(field_display)s\n"
+                "How about archiving the record instead?",

	lines.append(_("To avoid a mess, no company crossover allowed!"))
	lines.append(_("To avoid a mess, no company crossover is allowed!"))

	raise UserError(_("Oops! You can't change the period/account for posted entries! Only the draft ones are up for such an adventure like that!"))
	raise UserError(_("Oops! You can only change the period or account for posted entries! Other ones aren't up for an adventure like that!"))

	raise ValidationError(_("Once a document is posted, its type is set in stone and you can't change it anymore."))
	raise ValidationError(_("Once a document has been posted once, its type is set in stone and you can't change it anymore."))

	raise UserError(error_message % state_description_values.get(self[:1].state))
	raise UserError("You can't delete a time off request that is in %(leave_state)s state.", leave_state=state_description_values.get(self[:1].state))

	raise UserError(_("You can't delete a time off which is in the past"))
	raise UserError(_("You can't delete a time off request that is in the past."))

	raise UserError(error_message % (state_description_values.get(holiday.state),))
	raise UserError("You can't delete a time off request that is in %(leave_state)s state.", leave_state=state_description_values.get(holiday.state))

	raise ValidationError(_('Oh no! You don’t have enough money in your wallet to order that food! Contact your lunch manager to add some money in your wallet.'))
	raise ValidationError(_('Oh no! You don’t have enough money in your wallet to order your selected lunch! Contact your lunch manager to add some money to your wallet.'))

Uh oh!

[IMP] various: improve user error wording #178821

[IMP] various: improve user error wording #178821

Uh oh!

Conversation

ppr-odoo commented Sep 2, 2024 • edited by lordkrandel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Sep 2, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ppr-odoo commented Mar 2, 2025

Uh oh!

william-andre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ticodoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

william-andre commented Mar 3, 2025

Uh oh!

dylankiss left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ppr-odoo commented Sep 2, 2024 •

edited by lordkrandel

Loading