[17.0][FIX] sale_project: avoid error column reference "id" is ambiguous #179592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
celm1990
force-pushed
the
17.0-fix-sale_project_ambiguos_id
branch
from
838707b to
52b025c
Compare
xavierbol
reviewed
Nov 29, 2024
There was a problem hiding this comment.
That's a strange issue you got. :o
maybe we should also add the table alias on sale_line_id to be sure we will no longer that strange issue. 🤷🏼♂️
What do you think? 🙂
There was a problem hiding this comment.
@xavierbol Sorry for the delay! I have rebased and updated the code according to your suggestions.
Could you please review the changes and let me know if everything is okay for merging?
Thank you!
celm1990
force-pushed
the
17.0-fix-sale_project_ambiguos_id
branch
from
52b025c to
98b030d
Compare
|
LGTM, thanks for your contribution! 🙂 robodoo r+ |
|
@xavierbol you may want to rebuild or fix this PR as it has failed CI. |
robodoo
pushed a commit
that referenced
this pull request
Jan 24, 2025
closes #179592 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 25, 2025
closes odoo#179592 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
This was referenced Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
I can't reproduce the error in Runbot, but the error is real.
Try opening the project settings.
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr