[FIX] loyalty,sale: fix combo item deletion and disallow combos as free products #180695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ee products Combo items were sometimes erroneously deleted. This was because we compared "real" records (saved in DB) with "virtual" records (not saved in DB). In some situations, the "virtual" records were simply wrappers around the "real" record, in which case they should be considered equal, but they weren't. Combos need to be configured, so we can't allow them to be awarded as free products.
ltinel
force-pushed
the
master-fix-combo-item-deletion-loti
branch
from
32346fb to
b0472f4
Compare
Feyensv
approved these changes
Sep 19, 2024
robodoo
pushed a commit
that referenced
this pull request
Sep 19, 2024
…ee products Combo items were sometimes erroneously deleted. This was because we compared "real" records (saved in DB) with "virtual" records (not saved in DB). In some situations, the "virtual" records were simply wrappers around the "real" record, in which case they should be considered equal, but they weren't. Combos need to be configured, so we can't allow them to be awarded as free products. closes #180695 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combo items were sometimes erroneously deleted. This was because we compared "real" records (saved in DB) with "virtual" records (not saved in DB). In some situations, the "virtual" records were simply wrappers around the "real" record, in which case they should be considered equal, but they weren't.
Combos need to be configured, so we can't allow them to be awarded as free products.