[FW][FIX] crm,calendar: ensure activitygroup popup close on mobile on activityclicked #180711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up clicked Previous solution didn't work on mobile: document.body.click(); // hack to close dropdown Reproduce --- - -i mail,crm,helpdesk - On mobile: Click on "Activities" (fa-clock-o): - Selecting "Helpdesk Ticket" -> OK - Selecting "Lead/Opportunity" -> BUG - Selecting "Calendar activity" -> BUG (it opens the leads with activities, but it doesn't close the Activity popover, so user can't see it) Follows dropdown convention from --- 7b7a261 [IMP] web: Dropdowns menus unification opw-4171180 X-original-commit: b1d3a60
|
|
|
@nd-dew @tde-banana-odoo this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@nd-dew @tde-banana-odoo ci/runbot failed on this forward-port PR |
|
@robodoo r+ |
|
@tde-banana-odoo you may want to rebuild or fix this PR as it has failed CI. |
robodoo
pushed a commit
that referenced
this pull request
Sep 19, 2024
…up clicked Previous solution didn't work on mobile: document.body.click(); // hack to close dropdown Reproduce --- - -i mail,crm,helpdesk - On mobile: Click on "Activities" (fa-clock-o): - Selecting "Helpdesk Ticket" -> OK - Selecting "Lead/Opportunity" -> BUG - Selecting "Calendar activity" -> BUG (it opens the leads with activities, but it doesn't close the Activity popover, so user can't see it) Follows dropdown convention from --- 7b7a261 [IMP] web: Dropdowns menus unification opw-4171180 closes #180711 X-original-commit: b1d3a60 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
fw-bot
deleted the
master-saas-17.4-opw-4171180_ensure_activitygroup_popup_closed_on_activity_clicked-pian-WAmh-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous solution didn't work on mobile:
document.body.click(); // hack to close dropdown
Reproduce
(it opens the leads with activities,
but it doesn't close the Activity popover, so user can't see it)
opw-4171180
Forward-Port-Of: #180582