[FIX] website_sale: cart entries will not overflow in mobile eCommerce page #187698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @dabo-odoo LGTM 👍 In the future, we could also remove the picture to leave more place for the text in that specific use case. I'll investigate that on my side! @robodoo r+ Have a nice day! |
|
@dabo-odoo @chevalierv unable to stage: merge conflict |
…e page Before the change, in the mobile version of the eCommerce cart, if a product had a name that was too long or the font size was too big it would push the elements to its right offscreen. After the change, the overflow of a product name that is too long or too big gets replaced with ellipsis, keeping the elements to its right from beign pushed offscreen. task-4260720 opw-4253880
dabo-odoo
force-pushed
the
master-mobile-name-overflow-dabo
branch
from
7c611b1 to
2ca225c
Compare
|
Fixed the merge conflict @chevalierv |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 20, 2024
…e page Before the change, in the mobile version of the eCommerce cart, if a product had a name that was too long or the font size was too big it would push the elements to its right offscreen. After the change, the overflow of a product name that is too long or too big gets replaced with ellipsis, keeping the elements to its right from beign pushed offscreen. task-4260720 opw-4253880 closes #187698 Signed-off-by: Valentin Chevalier <vcr@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
There is an issue where product names that are too long or too big cause certain elements to be pushed offscreen in the mobile version of the cart in the eCommerce.
Current behavior before PR:
Before the change, in the mobile version of the eCommerce cart, if a product had a name that was too long or the font size was too big it would push the elements to its right offscreen.
Desired behavior after PR is merged:
After the change, the overflow of a product name that is too long or too big gets replaced with ellipsis, keeping the elements to its right from beign pushed offscreen.
task-4260720
opw-4253880
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr