[FIX] html_editor: properly handle `ctrl+click` and link preview in editor #188455

walidsahli · 2024-11-25T13:28:36Z

Problem:

Ctrl+click on a link in the editor does not open the link in a new tab.
Internal links with the format odoo/<model>/<record_id> do not display a proper preview. Instead, a warning toaster appears: "Action <model> not found, link preview is not available. Please check your URL is correct."

Solution:

Implement the same code as version 17.0 to handle ctrl+click for opening links in a new tab: 981290e
For internal links (odoo/<model>/<record_id>), validate the action_name as a model name. If valid, treat action_name as the model name for the link preview.

Steps to reproduce:

Open the editor.
Add a link with the path odoo/project.task/59.
Try Ctrl+click:
- Issue: The link does not open in a new tab.
Observe the warning toaster: "Action project.task not found, link preview is not available. Please check your URL is correct."

opw-4353235

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2024-11-25T13:28:38Z

Mtaylorr · 2024-11-25T15:02:31Z

addons/html_editor/controllers/main.py

I'm not sure if we want to add this here to be able to access the model directly when the model name is given because it will may access some other models like ir.http, bus.bus.... We need to check the spec here if we want to support this or not .
cc @Jinjiu96 , @dmo-odoo

Hello @walidsahli Thanks for the PR! I think @Mtaylorr has a very good point, we should only process the preview when it's not an abstract model. To do this I suggest to add other conditions in the if check:

Suggested change

if action_name in request.env:

if (action_name.startswith('m-') or '.' in action_name) and action_name in request.env and not request.env[action_name]._abstract:

By doing this, we ensure we don't access abstract models and also we restrict the action_name in this case to be a model name
cc @dmo-odoo

Hello @Mtaylorr Thanks for the catch, indeed we should restrict that.
Thanks for the suggestion @Jinjiu96 , i was not sure how to handle it in a safe way. i updated the commit please let me know if i missed anything.

Jinjiu96 · 2024-11-25T16:55:58Z

addons/html_editor/controllers/main.py

Here since it's actually a model's name we are using, it better to use model_name instead. Also, we cover another possibility of model name in the URL which starts with m-

Suggested change

model = request.env[action_name].with_context(context)

model_name = action_name.removeprefix('m-')

model = request.env[model_name].with_context(context)

Mtaylorr · 2024-11-26T14:20:11Z

addons/html_editor/tests/test_controller.py

@walidsahli , can you add a test for abstract model here to make sure he can't access it

dmo-odoo

Thanks for your work! I wrote a few comments.

dmo-odoo · 2024-12-04T12:14:53Z

addons/html_editor/static/src/main/link/link_plugin.js

Since both the issues and their respective fixes are completely unrelated from each other, they should be fixed in separated commits. It is ok to keep them in a single PR.

In the commit message for the _blank fix, it is better to link to the actual commit introducing the fix rather than on an arbitrary line of code in 17.0.

dmo-odoo · 2024-12-04T12:15:15Z

addons/html_editor/tests/test_controller.py

As you can see from this red sign on GitHub, the file is missing the empty line at the end.

dmo-odoo · 2024-12-04T12:22:19Z

addons/html_editor/controllers/main.py

Is this supposed to be a comment? Because right now, it's a string that just floats there in the middle of the code... ^^' I looked in Odoo's codebase (I haven't worked in Python for years) and it seems this kind of triple quoted strings are only used as comments for the docstring of functions (as per PEP 257), that is right after the function definition, but never in the middle of the code itself. Classical Python comments use #.

Of course, i'm sorry yea it should be a comment not a string.

**Problem**: Internal links with the format `odoo/<model>/<record_id>` do not display a proper preview. Instead, a warning toaster appears: _"Action `<model>` not found, link preview is not available. Please check your URL is correct."_ **Solution**: For internal links (`odoo/<model>/<record_id>`), validate the `action_name` as a model name. If valid, treat `action_name` as the model name for the link preview. **Steps to reproduce**: 1. Open the editor. 2. Add a link with the path `odoo/project.task/59`. 3. Press `Ctrl+click`. 4. Observe the warning toaster: _"Action project.task not found, link preview is not available. Please check your URL is correct."_ opw-4353235

**Problem**: `Ctrl+click` on a link in the editor does not open the link in a new tab. **Solution**: Implement the same code as version 17.0 to handle `ctrl+click` for opening links in a new tab: odoo@981290e **Steps to reproduce**: 1. Open the editor. 2. Add a link with the path `odoo/project.task/59`. 3. Try `Ctrl+click`: - **Issue**: The link does not open in a new tab. opw-4353235

dmo-odoo · 2024-12-18T08:35:12Z

@robodoo rebase-ff r+

robodoo · 2024-12-18T08:35:14Z

Merge method set to rebase and fast-forward.

**Problem**: Internal links with the format `odoo/<model>/<record_id>` do not display a proper preview. Instead, a warning toaster appears: _"Action `<model>` not found, link preview is not available. Please check your URL is correct."_ **Solution**: For internal links (`odoo/<model>/<record_id>`), validate the `action_name` as a model name. If valid, treat `action_name` as the model name for the link preview. **Steps to reproduce**: 1. Open the editor. 2. Add a link with the path `odoo/project.task/59`. 3. Press `Ctrl+click`. 4. Observe the warning toaster: _"Action project.task not found, link preview is not available. Please check your URL is correct."_ opw-4353235 Part-of: #188455 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

**Problem**: Internal links with the format `odoo/<model>/<record_id>` do not display a proper preview. Instead, a warning toaster appears: _"Action `<model>` not found, link preview is not available. Please check your URL is correct."_ **Solution**: For internal links (`odoo/<model>/<record_id>`), validate the `action_name` as a model name. If valid, treat `action_name` as the model name for the link preview. **Steps to reproduce**: 1. Open the editor. 2. Add a link with the path `odoo/project.task/59`. 3. Press `Ctrl+click`. 4. Observe the warning toaster: _"Action project.task not found, link preview is not available. Please check your URL is correct."_ opw-4353235 Part-of: odoo/odoo#188455 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

**Problem**: `Ctrl+click` on a link in the editor does not open the link in a new tab. **Solution**: Implement the same code as version 17.0 to handle `ctrl+click` for opening links in a new tab: odoo/odoo@981290e **Steps to reproduce**: 1. Open the editor. 2. Add a link with the path `odoo/project.task/59`. 3. Try `Ctrl+click`: - **Issue**: The link does not open in a new tab. opw-4353235 closes odoo/odoo#188455 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

walidsahli force-pushed the 18.0-opw-4353235-fix_link_preview_and_open_link_editor-wasa branch from dd25f68 to 768b514 Compare November 25, 2024 13:29

C3POdoo added the OE the report is linked to a support ticket (opw-...) label Nov 25, 2024

walidsahli force-pushed the 18.0-opw-4353235-fix_link_preview_and_open_link_editor-wasa branch 4 times, most recently from ee21b04 to adfd795 Compare November 25, 2024 14:10

Mtaylorr reviewed Nov 25, 2024

View reviewed changes

Jinjiu96 reviewed Nov 25, 2024

View reviewed changes

walidsahli force-pushed the 18.0-opw-4353235-fix_link_preview_and_open_link_editor-wasa branch 2 times, most recently from 243015b to 7aacef6 Compare November 26, 2024 14:13

Mtaylorr reviewed Nov 26, 2024

View reviewed changes

walidsahli force-pushed the 18.0-opw-4353235-fix_link_preview_and_open_link_editor-wasa branch from 7aacef6 to dbfa998 Compare November 26, 2024 14:41

walidsahli marked this pull request as ready for review November 26, 2024 17:21

C3POdoo requested a review from a team November 26, 2024 17:22

dmo-odoo reviewed Dec 4, 2024

View reviewed changes

walidsahli force-pushed the 18.0-opw-4353235-fix_link_preview_and_open_link_editor-wasa branch 3 times, most recently from dd0404f to 2d1e9a6 Compare December 5, 2024 08:36

walidsahli added 2 commits December 9, 2024 10:49

walidsahli force-pushed the 18.0-opw-4353235-fix_link_preview_and_open_link_editor-wasa branch from 2d1e9a6 to d854987 Compare December 9, 2024 09:49

robodoo closed this in 1ff4129 Dec 18, 2024

robodoo temporarily deployed to merge December 18, 2024 12:36 Inactive

fw-bot mentioned this pull request Dec 18, 2024

[FW][FIX] html_editor: properly handle ctrl+click and link preview in editor #190988

Closed

fw-bot deleted the 18.0-opw-4353235-fix_link_preview_and_open_link_editor-wasa branch January 1, 2025 14:19

	if action_name in request.env:
	if (action_name.startswith('m-') or '.' in action_name) and action_name in request.env and not request.env[action_name]._abstract:

	model = request.env[action_name].with_context(context)
	model_name = action_name.removeprefix('m-')
	model = request.env[model_name].with_context(context)

[FIX] html_editor: properly handle ctrl+click and link preview in editor #188455

[FIX] html_editor: properly handle ctrl+click and link preview in editor #188455

Uh oh!

Conversation

walidsahli commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Nov 25, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jinjiu96 Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmo-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmo-odoo commented Dec 18, 2024

Uh oh!

robodoo commented Dec 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[FIX] html_editor: properly handle `ctrl+click` and link preview in editor #188455

[FIX] html_editor: properly handle `ctrl+click` and link preview in editor #188455

walidsahli commented Nov 25, 2024 •

edited

Loading

Jinjiu96 Nov 25, 2024 •

edited

Loading