[FW][FIX] event_sale: avoid resetting state on install #189007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When event_sale is installed the combined compute for the status and state resets the state to "open" and "free", the default values when there is no sale order. We now check whether state and status were already set before writing on them. task-4364856 X-original-commit: e64d71d
|
|
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@reth-odoo @tde-banana-odoo the next pull request (#189037) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 1, 2024
When event_sale is installed the combined compute for the status and state resets the state to "open" and "free", the default values when there is no sale order. We now check whether state and status were already set before writing on them. task-4364856 closes #189007 X-original-commit: e64d71d Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com> Signed-off-by: Renaud Thiry (reth) <reth@odoo.com>
fw-bot
deleted the
saas-17.2-17.0-event-sale-prevent-overwriting-state-reth-hVi2-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When event_sale is installed the combined compute for the status and state resets the state to "open" and "free", the default values when there is no sale order.
We now check whether state and status were already set before writing on them.
task-4364856
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #188952