[FW][IMP] test_mail: make access tests independent from discuss models #189120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@tde-banana-odoo cherrypicking of pull request #186394 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
tde-banana-odoo
force-pushed
the
17.0-16.0-mail-access-tde-CjGw-fw
branch
2 times, most recently
from
6eff9be to
7df5611
Compare
Purpose is to separate tests about content from tests about access. It eases bugfixing and improving features while keeping other tests stable through versions. Task-4320561 X-Original-Commit: odoo/odoo@030288e
Purpose is to make tests independent from channel model which has its own access rules. We now use a test model with simple rules, allowing to simulate models with * public access; * portal access; * internal access; * admin access; Tests are rewritten to be more concise and precise and use this new model. This is done in stable to keep coherency in tests codebase. It also eases writing bugfixes as tests won't have to be modified during forward port process. Finally it allows to backport improvements or fixes in later versions if it applies to previous versions. Task-4320561 X-Original-Commit: odoo/odoo@6370ca1
Use sudo when accessing opportunities messages to update. Individual access rights should not prevent from updating necessary messages when moving them and updating subject due to opportunity merge. Task-4320561 X-Original-Commit: odoo/odoo@93fbc8d
tde-banana-odoo
force-pushed
the
17.0-16.0-mail-access-tde-CjGw-fw
branch
from
b02391e to
283c200
Compare
|
@robodoo r+ rebase-merge |
|
Merge method set to rebase and merge, using the PR as merge commit message. |
robodoo
pushed a commit
that referenced
this pull request
Nov 29, 2024
Purpose is to make tests independent from channel model which has its own access rules. We now use a test model with simple rules, allowing to simulate models with * public access; * portal access; * internal access; * admin access; Tests are rewritten to be more concise and precise and use this new model. This is done in stable to keep coherency in tests codebase. It also eases writing bugfixes as tests won't have to be modified during forward port process. Finally it allows to backport improvements or fixes in later versions if it applies to previous versions. Task-4320561 X-original-commit: 6370ca1 Part-of: #189120 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Nov 29, 2024
Use sudo when accessing opportunities messages to update. Individual access rights should not prevent from updating necessary messages when moving them and updating subject due to opportunity merge. Task-4320561 X-original-commit: 93fbc8d Part-of: #189120 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
added a commit
that referenced
this pull request
Nov 29, 2024
Improve access related tests for mail.message and their sub models. Currently tests are dependent on discuss.channel model, and not always written in a clear way. Understanding the purpose of each test is not crystal clear. We now use a test model with simple rules, defined in test_mail addon. It allows to simulate models with * public access; * portal access; * internal access; * admin access; using ACLs and ir.rules. Tests are rewritten to be more concise and precise and use new models. This is done in stable to keep coherency in tests codebase. It also eases writing bugfixes as tests won't have to be modified during forward port process. Finally it allows to backport improvements or fixes in later versions if it applies to previous versions. Task-4320561 closes #189120 Forward-port-of: #186394 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This was referenced Nov 29, 2024
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Nov 29, 2024
Purpose is to separate tests about content from tests about access. It eases bugfixing and improving features while keeping other tests stable through versions. Task-4320561 X-original-commit: odoo/odoo@030288e Part-of: odoo#189120 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Nov 29, 2024
Purpose is to make tests independent from channel model which has its own access rules. We now use a test model with simple rules, allowing to simulate models with * public access; * portal access; * internal access; * admin access; Tests are rewritten to be more concise and precise and use this new model. This is done in stable to keep coherency in tests codebase. It also eases writing bugfixes as tests won't have to be modified during forward port process. Finally it allows to backport improvements or fixes in later versions if it applies to previous versions. Task-4320561 X-original-commit: odoo/odoo@6370ca1 Part-of: odoo#189120 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Nov 29, 2024
Use sudo when accessing opportunities messages to update. Individual access rights should not prevent from updating necessary messages when moving them and updating subject due to opportunity merge. Task-4320561 X-original-commit: odoo/odoo@93fbc8d Part-of: odoo#189120 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
added a commit
that referenced
this pull request
Nov 29, 2024
Improve access related tests for mail.message and their sub models. Currently tests are dependent on discuss.channel model, and not always written in a clear way. Understanding the purpose of each test is not crystal clear. We now use a test model with simple rules, defined in test_mail addon. It allows to simulate models with * public access; * portal access; * internal access; * admin access; using ACLs and ir.rules. Tests are rewritten to be more concise and precise and use new models. This is done in stable to keep coherency in tests codebase. It also eases writing bugfixes as tests won't have to be modified during forward port process. Finally it allows to backport improvements or fixes in later versions if it applies to previous versions. Task-4320561 closes #189181 Forward-port-of: #189120 Forward-port-of: #186394 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
added a commit
that referenced
this pull request
Nov 29, 2024
Improve access related tests for mail.message and their sub models. Currently tests are dependent on discuss.channel model, and not always written in a clear way. Understanding the purpose of each test is not crystal clear. We now use a test model with simple rules, defined in test_mail addon. It allows to simulate models with * public access; * portal access; * internal access; * admin access; using ACLs and ir.rules. Tests are rewritten to be more concise and precise and use new models. This is done in stable to keep coherency in tests codebase. It also eases writing bugfixes as tests won't have to be modified during forward port process. Finally it allows to backport improvements or fixes in later versions if it applies to previous versions. Task-4320561 closes #189202 Forward-port-of: #189120 Forward-port-of: #186394 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
ebirbe
reviewed
Nov 30, 2024
| Command.unlink(self.env.ref('base.group_user').id), | ||
| Command.link(self.env.ref('base.group_portal').id), | ||
| (3, self.env.ref('base.group_user').id), | ||
| (4, self.env.ref('base.group_portal').id), |
There was a problem hiding this comment.
Hello guys, just curious about why using directly the number (3 and 4) instead of the Command is considered an improvement on this commit?
There was a problem hiding this comment.
It is not ... I had conflicts, removed Command when resolving the conflict, then had an issue with Command usage and fall back on using numbers as I find it easier. But that should effectively not be done in stable, even if not really annoying in tests.
robodoo
added a commit
that referenced
this pull request
Dec 2, 2024
Improve access related tests for mail.message and their sub models. Currently tests are dependent on discuss.channel model, and not always written in a clear way. Understanding the purpose of each test is not crystal clear. We now use a test model with simple rules, defined in test_mail addon. It allows to simulate models with * public access; * portal access; * internal access; * admin access; using ACLs and ir.rules. Tests are rewritten to be more concise and precise and use new models. This is done in stable to keep coherency in tests codebase. It also eases writing bugfixes as tests won't have to be modified during forward port process. Finally it allows to backport improvements or fixes in later versions if it applies to previous versions. Task-4320561 closes #189181 Forward-port-of: #189120 Forward-port-of: #186394 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve access related tests for mail.message and their sub models. Currently
tests are dependent on discuss.channel model, and not always written in a
clear way. Understanding the purpose of each test is not crystal clear.
We now use a test model with simple rules, defined in test_mail addon. It
allows to simulate models with
using ACLs and ir.rules. Tests are rewritten to be more concise and precise
and use new models.
This is done in stable to keep coherency in tests codebase. It also eases
writing bugfixes as tests won't have to be modified during forward port
process. Finally it allows to backport improvements or fixes in later
versions if it applies to previous versions.
Task-4320561
Forward-Port-Of: #186394