[FW][FIX] mail: scroll to not yet loaded pinned message #189382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robodoo
added
forwardport
|
|
|
@tsm-odoo cherrypicking of pull request #189282 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
tsm-odoo
force-pushed
the
master-saas-17.4-fix_scroll_to_unknown-tsm-0W-n-fw
branch
from
47ccbc7 to
78ee061
Compare
tsm-odoo
reviewed
Dec 3, 2024
|
@tsm-odoo 'ci/runbot' failed on this reviewed PR. |
tsm-odoo
force-pushed
the
master-saas-17.4-fix_scroll_to_unknown-tsm-0W-n-fw
branch
from
78ee061 to
442a738
Compare
Before this PR, clicking on the "user pinned a message to the channel" notification linked to a not yet loaded message would not scroll to the pinned message. This issue arises because the `highlightMessage` function does nothing if the message's thread is different from the current one. However, when a message is unknown, the thread is also unknown, and the function does nothing. The notification is only displayed in the origin thread of the message, so we can safely pass this information, assuming the message thread and the notification thread are the same. X-original-commit: e82929b
tsm-odoo
force-pushed
the
master-saas-17.4-fix_scroll_to_unknown-tsm-0W-n-fw
branch
from
442a738 to
ebd4771
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 5, 2024
Before this PR, clicking on the "user pinned a message to the channel" notification linked to a not yet loaded message would not scroll to the pinned message. This issue arises because the `highlightMessage` function does nothing if the message's thread is different from the current one. However, when a message is unknown, the thread is also unknown, and the function does nothing. The notification is only displayed in the origin thread of the message, so we can safely pass this information, assuming the message thread and the notification thread are the same. closes #189382 X-original-commit: e82929b Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
alexkuhn
deleted the
master-saas-17.4-fix_scroll_to_unknown-tsm-0W-n-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, clicking on the "user pinned a message to the channel" notification linked to a not yet loaded message would not scroll to the pinned message.
This issue arises because the
highlightMessagefunction does nothing if the message's thread is different from the current one. However, when a message is unknown, the thread is also unknown, and the function does nothing.The notification is only displayed in the origin thread of the message, so we can safely pass this information, assuming the message thread and the notification thread are the same.
Forward-Port-Of: #189323
Forward-Port-Of: #189282