Skip to content

Conversation

mano-odoo
Copy link
Contributor

@mano-odoo mano-odoo commented Dec 6, 2024

The goal is to introduce a visual differentiation in the Order Overview
of the checkout process to differentiate rented items & subscriptions items from the purchased ones.

This PR introduces the cart_content template to handle cart_lines variations. Font-sizes and spacing are slightly reviewed for better readability.

_changeCartQuantity is reviewed to ensure the page displays updated information.

Enterprise PR: https://github.com/odoo/enterprise/pull/75301

task-3531721


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Dec 6, 2024

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Dec 6, 2024
@mano-odoo mano-odoo force-pushed the master-wsale-checkout-distinguish-rental-items-mano branch from 56a2ff4 to c326c7e Compare December 6, 2024 15:15
@chgo-odoo chgo-odoo self-requested a review December 18, 2024 09:06
Copy link
Contributor

@chgo-odoo chgo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to rebase to solve conflicts.

@mano-odoo mano-odoo force-pushed the master-wsale-checkout-distinguish-rental-items-mano branch 2 times, most recently from 3ae6b24 to b984a2e Compare January 9, 2025 14:43
@mano-odoo mano-odoo marked this pull request as ready for review January 9, 2025 16:24
@C3POdoo C3POdoo requested a review from a team January 9, 2025 16:26
Copy link
Contributor

@chevalierv chevalierv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on your enterprise PR

@chevalierv chevalierv force-pushed the master-wsale-checkout-distinguish-rental-items-mano branch 3 times, most recently from bb66de1 to bcdea08 Compare January 13, 2025 13:36
@mano-odoo mano-odoo force-pushed the master-wsale-checkout-distinguish-rental-items-mano branch from bcdea08 to 0c4300b Compare January 13, 2025 15:57
@mano-odoo mano-odoo changed the title [IMP] website_sale: distinguish checkout rental item [IMP] website_sale: differentiate checkout items Jan 13, 2025
@chevalierv chevalierv force-pushed the master-wsale-checkout-distinguish-rental-items-mano branch 3 times, most recently from 04a05e6 to bc8838c Compare January 17, 2025 15:28
@chevalierv chevalierv requested a review from ltinel January 17, 2025 15:30
The goal is to introduce a visual differentiation in the Order Overview
of the checkout process.

This commit introduces the `cart_content` template to handle cart_lines
iterable variations. Font-sizes and spacing are slightly reviewed for
better readability.

`_changeCartQuantity` is reviewed to ensure the page displays updated
information (and to refresh the input of rented items).

task-3531721

Co-authored-by: mano-odoo <mano@odoo.com>
@chevalierv chevalierv force-pushed the master-wsale-checkout-distinguish-rental-items-mano branch from bc8838c to 3a10361 Compare January 17, 2025 15:42
@chevalierv chevalierv requested a review from Feyensv January 17, 2025 15:44
@mano-odoo
Copy link
Contributor Author

@chevalierv we had a discussion with @Jean-boje, we will not go for this approach. We will review the design to differentiate the products with badges.

@mano-odoo mano-odoo marked this pull request as draft January 23, 2025 12:04
@mano-odoo mano-odoo removed the request for review from ltinel January 23, 2025 12:04
@mano-odoo
Copy link
Contributor Author

Task cancelled in favor of task-4512956

@chevalierv chevalierv closed this Jan 24, 2025
@xmo-odoo xmo-odoo deleted the master-wsale-checkout-distinguish-rental-items-mano branch March 7, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants