[FW][FIX] mail: normalized when formatting email_to / email_cc #190033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robodoo
added
forwardport
|
@tde-banana-odoo cherrypicking of pull request #189409 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
tde-banana-odoo
force-pushed
the
17.0-16.0-mail-validation-tde-ZSQp-fw
branch
2 times, most recently
from
4cda95b to
3bade66
Compare
C3POdoo
requested review from
a team,
Gorash and
xmo-odoo
and removed request for
a team
When preparing final outgoing email, partner email is normalized. We take their formatted email, which is their name and their normalized email. However email_to and email_cc are taken from input using 'email_split(_and_format)', which finds emails but do not format them. This leads to incoherent behavior as most emails are normalized as we generally always use partners, but not all. In this commit we now split, normalize and format email_to and email_cc in outgoing emails. This fixes a first issue where name are lost if a formatted email was entered in email_cc field. Only address was kept, now the name is correctly found and put back. This also fixes an issue for validated email detection, in order to compare normalized emails. This was introduced at odoo#185793 and may skip valid emails entered in email_to or email_cc. This commit backports a tool introduced at odoo/odoo@dd4709e which aims at allowing a quick convert from a string holding emails to a list of nicely formatted emails, using normalize version of email addresses. This is the standard we use in most flows. Task-4376876 Followup of task-3704658 X-Original-Commit: odoo/odoo@2baa481
tde-banana-odoo
force-pushed
the
17.0-16.0-mail-validation-tde-ZSQp-fw
branch
from
3bade66 to
9729ffa
Compare
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 X-Original-Commit: odoo/odoo@bdccc57
tde-banana-odoo
force-pushed
the
17.0-16.0-mail-validation-tde-ZSQp-fw
branch
from
9729ffa to
74ff80b
Compare
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
|
@tde-banana-odoo staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/71863130) |
|
@robodoo retry |
|
@tde-banana-odoo staging failed: ci/runbot on 6629d8663218076d5d0c7fa8120d488b26fa0814 (view more at https://runbot.odoo.com/runbot/build/71897254) |
|
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Dec 12, 2024
When preparing final outgoing email, partner email is normalized. We take their formatted email, which is their name and their normalized email. However email_to and email_cc are taken from input using 'email_split(_and_format)', which finds emails but do not format them. This leads to incoherent behavior as most emails are normalized as we generally always use partners, but not all. In this commit we now split, normalize and format email_to and email_cc in outgoing emails. This fixes a first issue where name are lost if a formatted email was entered in email_cc field. Only address was kept, now the name is correctly found and put back. This also fixes an issue for validated email detection, in order to compare normalized emails. This was introduced at #185793 and may skip valid emails entered in email_to or email_cc. This commit backports a tool introduced at dd4709e which aims at allowing a quick convert from a string holding emails to a list of nicely formatted emails, using normalize version of email addresses. This is the standard we use in most flows. Task-4376876 Followup of task-3704658 X-original-commit: 2baa481 Part-of: #190033 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 12, 2024
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes #190033 X-original-commit: bdccc57 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
@robodoo retry |
|
@tde-banana-odoo retry makes no sense when the PR is not in error. |
This was referenced Dec 12, 2024
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 12, 2024
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes odoo#190033 X-original-commit: odoo/odoo@bdccc57 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 12, 2024
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes #190033 closes #190531 X-original-commit: bdccc57 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 12, 2024
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes odoo#190033 X-original-commit: 0116f66 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 12, 2024
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes #190033 closes #190588 X-original-commit: 0116f66 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 16, 2024
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes odoo#190033 closes odoo#190531 X-original-commit: odoo/odoo@bdccc57 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Dec 16, 2024
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes #190033 closes #190531 closes #190594 X-original-commit: bdccc57 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Jan 24, 2025
Due to history reasons, input given when inviting users is parsed in a simple way. However this create issues, notably because Odoo heavily relies on normalized emails. We therefore use the same heuristics as when creating partners given a potentially formatted input. Task-4376876 Followup of task-3704658 closes odoo/odoo#190033 closes odoo/odoo#190588 X-original-commit: 0116f6624439197f2dd875672cf6f3b1d4dfafda Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing final outgoing email, partner email is normalized. We take their formatted email, which is their name and their normalized email. However email_to and email_cc are taken from input using 'email_split(_and_format)', which finds emails but do not format them.
This leads to incoherent behavior as most emails are normalized as we generally always use partners, but not all. In this commit we now split, normalize and format email_to and email_cc in outgoing emails.
This fixes a first issue where name are lost if a formatted email was entered in email_cc field. Only address was kept, now the name is correctly found and put back.
This also fixes an issue for validated email detection, in order to compare normalized emails. This was introduced at #185793 and may skip valid emails entered in email_to or email_cc.
This commit backports a tool introduced at dd4709e which aims at allowing a quick convert from a string holding emails to a list of nicely formatted emails, using normalize version of email addresses. This is the standard we use in most flows.
Task-4376876
Followup of task-3704658
Forward-Port-Of: #189409