[FW][FIX] stock: adapt _onchange_location_in for New records

[fw-bot]

Steps to reproduce:

• Enable Multi-Steps Routes in the settings
• Inventory > Configuration > Warehouse Management > Locations
• Pick any location
• With studio add the one2Many field Store to sublocation (location_out_id of stock.putaway.rule) > Close studio
• Try to add a line on the associated list

> Traceback

Cause of the issue:

Adding a line will trigger an onchange of thestock.putaway.rule model in order to compute the default data of the new subrecord. However, the code will crash during the _search_count of the _onchange_location_in because of an invalid domain:

odoo/addons/stock/models/product_strategy.py

Lines 80 to 88 in 29939aa

	@api.onchange('location_in_id')
	def _onchange_location_in(self):
	child_location_count = 0
	if self.location_out_id:
	child_location_count = self.env['stock.location'].search_count([
	('id', '=', self.location_out_id.id),
	('id', 'child_of', self.location_in_id.id),
	('id', '!=', self.location_in_id.id),
	])

THis crashed since in our case the location_out_id will be a new record created during the onchange to represent the 'stock.location' and from which we are looking at the form. As such, a NewId will be given and treated as an integer in the domain leading to a traceback when the db is served.

Fix:

Onchange method should be robust with respect to the usage of New records and hence the records used here should be replace by their origin if it even exists.

opw-4126731

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #189878
Forward-Port-Of: #188053

[robodoo]

[fw-bot]

@lase-odoo @Whenrow this PR targets master and is the last of the forward-port chain containing:

• [FW][FIX] stock: adapt _onchange_location_in for New records #190415
• [FW][FIX] stock: adapt _onchange_location_in for New records #190409

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[fw-bot]

@lase-odoo @Whenrow this forward port of #188053 is awaiting action (not merged or closed).

[lase-odoo]

robodoo r+