[FW][FIX] account: allow decimal hook in vat amount edition #190482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@yosa-odoo @h4818 cherrypicking of pull request #189582 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
yosa-odoo
force-pushed
the
17.0-16.0-opw-4284370-numpad_decimal_vat_edit-yosa-YDLE-fw
branch
from
ecfbbdf to
00556b1
Compare
|
tested locally |
|
@yosa-odoo @h4818 this forward port of #189582 is awaiting action (not merged or closed). |
Steps to reproduce: - define your language as French/BE - create a bill (facture fournisseur) - edit the vat with '20.13' using the numpad decimal key Issue: the amount is '2013.00' Cause: numpad decimal in belgian layout is a comma `,` which in this is interpreted as a thousands separator. Solution: Use the `useNumpadDecimal` hook opw-4284370 X-original-commit: b933e82
yosa-odoo
force-pushed
the
17.0-16.0-opw-4284370-numpad_decimal_vat_edit-yosa-YDLE-fw
branch
from
00556b1 to
0d2216a
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 16, 2024
Steps to reproduce: - define your language as French/BE - create a bill (facture fournisseur) - edit the vat with '20.13' using the numpad decimal key Issue: the amount is '2013.00' Cause: numpad decimal in belgian layout is a comma `,` which in this is interpreted as a thousands separator. Solution: Use the `useNumpadDecimal` hook opw-4284370 closes #190482 X-original-commit: b933e82 Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com> Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com>
This was referenced Dec 16, 2024
fw-bot
deleted the
17.0-16.0-opw-4284370-numpad_decimal_vat_edit-yosa-YDLE-fw
branch
BurkhalterY
pushed a commit
to Burkhalter-IT/odoo
that referenced
this pull request
Jan 28, 2025
Steps to reproduce: - define your language as French/BE - create a bill (facture fournisseur) - edit the vat with '20.13' using the numpad decimal key Issue: the amount is '2013.00' Cause: numpad decimal in belgian layout is a comma `,` which in this is interpreted as a thousands separator. Solution: Use the `useNumpadDecimal` hook opw-4284370 closes odoo#190482 X-original-commit: b933e82 Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com> Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
the amount is '2013.00'
Cause:
numpad decimal in belgian layout is a comma
,which in this is interpreted as a thousands separator.Solution:
Use the
useNumpadDecimalhookopw-4284370
Forward-Port-Of: #189582