Skip to content

[FW][REF] web_tour: decrease debounce delay to 300ms #190729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FW][REF] web_tour: decrease debounce delay to 300ms #190729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions addons/pos_self_order/static/tests/tours/self_order_kiosk_tour.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import * as ProductPage from "@pos_self_order/../tests/tours/utils/product_page_
import * as Numpad from "@point_of_sale/../tests/generic_helpers/numpad_util";

registry.category("web_tour.tours").add("self_kiosk_each_table_takeaway_in", {
checkDelay: 100,
steps: () => [
Utils.checkIsNoBtn("My Order"),
Utils.clickBtn("Order Now"),
Expand All @@ -25,6 +26,7 @@ registry.category("web_tour.tours").add("self_kiosk_each_table_takeaway_in", {
});

registry.category("web_tour.tours").add("self_kiosk_each_table_takeaway_out", {
checkDelay: 100,
steps: () => [
Utils.checkIsNoBtn("My Order"),
Utils.clickBtn("Order Now"),
Expand All @@ -40,6 +42,7 @@ registry.category("web_tour.tours").add("self_kiosk_each_table_takeaway_out", {
});

registry.category("web_tour.tours").add("self_kiosk_each_counter_takeaway_in", {
checkDelay: 100,
steps: () => [
Utils.checkIsNoBtn("My Order"),
Utils.clickBtn("Order Now"),
Expand All @@ -59,6 +62,7 @@ registry.category("web_tour.tours").add("self_kiosk_each_counter_takeaway_in", {
});

registry.category("web_tour.tours").add("self_kiosk_each_counter_takeaway_out", {
checkDelay: 100,
steps: () => [
Utils.checkIsNoBtn("My Order"),
Utils.clickBtn("Order Now"),
Expand All @@ -76,6 +80,7 @@ registry.category("web_tour.tours").add("self_kiosk_each_counter_takeaway_out",
});

registry.category("web_tour.tours").add("self_order_kiosk_cancel", {
checkDelay: 100,
steps: () => [
Utils.checkIsNoBtn("My Order"),
Utils.clickBtn("Order Now"),
Expand All @@ -92,6 +97,7 @@ registry.category("web_tour.tours").add("self_order_kiosk_cancel", {
});

registry.category("web_tour.tours").add("self_simple_order", {
checkDelay: 100,
steps: () => [
Utils.checkIsNoBtn("My Order"),
Utils.clickBtn("Order Now"),
Expand All @@ -105,6 +111,7 @@ registry.category("web_tour.tours").add("self_simple_order", {
});

registry.category("web_tour.tours").add("self_order_price_null", {
checkDelay: 100,
steps: () => [
Utils.checkIsNoBtn("My Order"),
Utils.clickBtn("Order Now"),
Expand All @@ -118,6 +125,7 @@ registry.category("web_tour.tours").add("self_order_price_null", {
});

registry.category("web_tour.tours").add("self_order_language_changes", {
checkDelay: 100,
steps: () => [
LandingPage.checkLanguageSelected("English"),
LandingPage.checkCountryFlagShown("us"),
Expand Down
5 changes: 2 additions & 3 deletions addons/web_tour/static/src/tour_service/tour_automatic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export class TourAutomatic {
const macroSteps = this.steps
.filter((step) => step.index >= this.currentIndex)
.flatMap((step) => {
const timeout = (step.timeout || 10000) + this.config.stepDelay;
return [
{
action: async () => {
Expand All @@ -63,7 +62,7 @@ export class TourAutomatic {
return this.previousStepIsJustACheck ? 0 : null;
},
trigger: () => step.findTrigger(),
timeout,
timeout: (step.timeout || 10000) + this.config.stepDelay,
action: async () => {
if (this.checkForUndeterminisms) {
try {
Expand Down Expand Up @@ -113,7 +112,7 @@ export class TourAutomatic {

this.macro = new Macro({
name: this.name,
checkDelay: this.checkDelay || 400,
checkDelay: this.checkDelay || 300,
steps: macroSteps,
onError: (error) => {
this.throwError([error]);
Expand Down