Skip to content

Conversation

mash-odoo
Copy link
Contributor

@mash-odoo mash-odoo commented Dec 20, 2024

Steps to Reproduce:

  • Navigate to /shop .
  • Open editor mode and select a product.
  • Use the reorder widget from the editor panel to change the product's position.
  • Notice the product jumps 2 positions instead of 1 when reordered.

Issue:

  • Two products, 'Warranty' and 'Chair Floor Protection', have the same website_sequence. This causes the reorder logic to malfunction, making products jump 2 positions when one is placed in front or behind these two.

Fix:

  • Updated the website_sequence of conflicting products to ensure all products have unique values.

Affected Versions: 16.0~master
opw-4150099

@robodoo
Copy link
Contributor

robodoo commented Dec 20, 2024

Pull request status dashboard

@mash-odoo mash-odoo requested a review from kcv-odoo December 20, 2024 04:39
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Dec 20, 2024
@mash-odoo mash-odoo changed the base branch from 16.0 to master December 20, 2024 06:57
@mash-odoo mash-odoo force-pushed the 16.0-website-sale-fix-reorder-product-widget-mash branch 2 times, most recently from ab62de7 to 3ab0b04 Compare December 20, 2024 09:03
@mash-odoo mash-odoo requested a review from kcv-odoo December 20, 2024 09:13
@kcv-odoo kcv-odoo marked this pull request as ready for review December 30, 2024 07:28
@kcv-odoo kcv-odoo requested a review from livaios December 30, 2024 07:29
Copy link
Contributor

@livaios livaios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself LGTM
However the upgrade script needs to target 16.0 not 18.1

@mash-odoo mash-odoo force-pushed the 16.0-website-sale-fix-reorder-product-widget-mash branch from 3ab0b04 to 336af75 Compare January 2, 2025 12:45
Steps to Reproduce:
- Navigate to /shop .
- Open editor mode and select a product.
- Use the reorder widget from the editor panel to change the product's position.
- Notice the product jumps 2 positions instead of 1 when reordered.

Issue:
- Two products, 'Warranty' and 'Chair Floor Protection', have the same
website_sequence. This causes the reorder logic to malfunction, making products
jump 2 positions when one is placed in front or behind these two.

Fix:
- Updated the website_sequence of conflicting products to ensure all products
have unique values.

Affected Versions: 16.0~master
opw-4150099
@mash-odoo mash-odoo changed the base branch from master to 16.0 January 2, 2025 12:50
@mash-odoo
Copy link
Contributor Author

Heyy @livaios,
As per our discussion, I have re-targeted the branch back to 16.0 again! 😄

@mash-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Jan 29, 2025

@mash-odoo you can't review+.

@Feyensv
Copy link
Contributor

Feyensv commented Jan 30, 2025

@robodoo r+ delegate+

robodoo pushed a commit that referenced this pull request Jan 30, 2025
Steps to Reproduce:
- Navigate to /shop .
- Open editor mode and select a product.
- Use the reorder widget from the editor panel to change the product's position.
- Notice the product jumps 2 positions instead of 1 when reordered.

Issue:
- Two products, 'Warranty' and 'Chair Floor Protection', have the same
website_sequence. This causes the reorder logic to malfunction, making products
jump 2 positions when one is placed in front or behind these two.

Fix:
- Updated the website_sequence of conflicting products to ensure all products
have unique values.

Affected Versions: 16.0~master
opw-4150099

closes #191297

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo closed this Jan 30, 2025
@fw-bot fw-bot deleted the 16.0-website-sale-fix-reorder-product-widget-mash branch February 13, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OE the report is linked to a support ticket (opw-...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants