-
Notifications
You must be signed in to change notification settings - Fork 30k
[FIX] website_sale: resolve product reorder issue in shop editor #191297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mash-odoo
wants to merge
1
commit into
odoo:16.0
from
odoo-dev:16.0-website-sale-fix-reorder-product-widget-mash
Closed
[FIX] website_sale: resolve product reorder issue in shop editor #191297
mash-odoo
wants to merge
1
commit into
odoo:16.0
from
odoo-dev:16.0-website-sale-fix-reorder-product-widget-mash
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcv-odoo
reviewed
Dec 20, 2024
ab62de7
to
3ab0b04
Compare
livaios
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix itself LGTM
However the upgrade script needs to target 16.0 not 18.1
3ab0b04
to
336af75
Compare
Steps to Reproduce: - Navigate to /shop . - Open editor mode and select a product. - Use the reorder widget from the editor panel to change the product's position. - Notice the product jumps 2 positions instead of 1 when reordered. Issue: - Two products, 'Warranty' and 'Chair Floor Protection', have the same website_sequence. This causes the reorder logic to malfunction, making products jump 2 positions when one is placed in front or behind these two. Fix: - Updated the website_sequence of conflicting products to ensure all products have unique values. Affected Versions: 16.0~master opw-4150099
Heyy @livaios, |
@robodoo r+ |
@mash-odoo you can't review+. |
@robodoo r+ delegate+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 30, 2025
Steps to Reproduce: - Navigate to /shop . - Open editor mode and select a product. - Use the reorder widget from the editor panel to change the product's position. - Notice the product jumps 2 positions instead of 1 when reordered. Issue: - Two products, 'Warranty' and 'Chair Floor Protection', have the same website_sequence. This causes the reorder logic to malfunction, making products jump 2 positions when one is placed in front or behind these two. Fix: - Updated the website_sequence of conflicting products to ensure all products have unique values. Affected Versions: 16.0~master opw-4150099 closes #191297 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
This was referenced Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce:
Issue:
Fix:
Affected Versions: 16.0~master
opw-4150099