[FIX] website_sale: fix overlapping terms & conditions #191346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chgo-odoo
force-pushed
the
18.0-fix-website-sale-termsncondition-mobile-overlap-chgo
branch
2 times, most recently
from
08907f9 to
115976c
Compare
chgo-odoo
force-pushed
the
18.0-fix-website-sale-termsncondition-mobile-overlap-chgo
branch
2 times, most recently
from
f50ada3 to
8ad4b44
Compare
mano-odoo
approved these changes
Dec 20, 2024
|
@robodoo delegate=vchu-odoo |
vchu-odoo
approved these changes
Dec 23, 2024
This commit fixes an issues about the terms & conditions overlapping the rest of the content on the `website_sale` payment page. Prior to this commit, the terms & conditions was positioned using a `position-absolute` with a `bottom-0`, resulting in the element extending to the topside if its content is very long. This led to some overlapping issues with the others elements of the view. To prevent this issue to happen, we position the element with a `top-100` and remove the `<div>` that aimed to handle the spacing at the bottom. We now manage this spacing with a utility class. opw-4373853
chgo-odoo
force-pushed
the
18.0-fix-website-sale-termsncondition-mobile-overlap-chgo
branch
from
8ad4b44 to
6cbe2f8
Compare
|
Thank you for the changes! @robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 23, 2024
This commit fixes an issues about the terms & conditions overlapping the rest of the content on the `website_sale` payment page. Prior to this commit, the terms & conditions was positioned using a `position-absolute` with a `bottom-0`, resulting in the element extending to the topside if its content is very long. This led to some overlapping issues with the others elements of the view. To prevent this issue to happen, we position the element with a `top-100` and remove the `<div>` that aimed to handle the spacing at the bottom. We now manage this spacing with a utility class. opw-4373853 closes #191346 Signed-off-by: Valeriya Chuprina (vchu) <vchu@odoo.com>
This was referenced Dec 23, 2024
fw-bot
deleted the
18.0-fix-website-sale-termsncondition-mobile-overlap-chgo
branch
BurkhalterY
pushed a commit
to Burkhalter-IT/odoo
that referenced
this pull request
Jan 28, 2025
This commit fixes an issues about the terms & conditions overlapping the rest of the content on the `website_sale` payment page. Prior to this commit, the terms & conditions was positioned using a `position-absolute` with a `bottom-0`, resulting in the element extending to the topside if its content is very long. This led to some overlapping issues with the others elements of the view. To prevent this issue to happen, we position the element with a `top-100` and remove the `<div>` that aimed to handle the spacing at the bottom. We now manage this spacing with a utility class. opw-4373853 closes odoo#191346 Signed-off-by: Valeriya Chuprina (vchu) <vchu@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issues about the terms & conditions overlapping the rest of the content on the
website_salepayment page.Prior to this PR, the terms & conditions was positioned using a
position-absolutewith abottom-0, resulting in the element extending to the topside if its content is very long. This led to some overlapping issues with the others elements of the view.To prevent this issue to happen, we position the element with a
top-100and remove the<div>that aimed to handle the spacing at the bottom. We now manage this spacing with a utility class.opw-4373853
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr