[FW][FIX] website_slides: fix website description field #191566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the parameter "sanitize_overridable=True" to the "description" field of "website_slides" slides. It means that the description can now be properly edited as an user with enough rights. The issue is that the "slide.description" field is sanitized after saving a "slide/*" page, which removes "<button>" elements. This is not easily testable in version 16.0 because no blocks contain "<button>" elements. However, starting from version 18.0, new blocks like the "accordion" block include buttons, and these are removed after saving a "slide/*" page when they are dropped into it. opw-4273436 X-original-commit: 0cd42f8
|
|
|
This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Dec 27, 2024
This commit adds the parameter "sanitize_overridable=True" to the "description" field of "website_slides" slides. It means that the description can now be properly edited as an user with enough rights. The issue is that the "slide.description" field is sanitized after saving a "slide/*" page, which removes "<button>" elements. This is not easily testable in version 16.0 because no blocks contain "<button>" elements. However, starting from version 18.0, new blocks like the "accordion" block include buttons, and these are removed after saving a "slide/*" page when they are dropped into it. opw-4273436 closes #191566 X-original-commit: 0cd42f8 Signed-off-by: Outagant Mehdi (mou) <mou@odoo.com> Signed-off-by: Benjamin Vray (bvr) <bvr@odoo.com>
fw-bot
deleted the
saas-17.4-16.0-fix-editing-slide-description-bvr-lwt0-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the parameter
sanitize_overridable=Trueto thedescriptionfield ofwebsite_slidesslides. It means that the description can now be properly edited as an user with enough rights.The issue is that the
slide.descriptionfield is sanitized after saving aslide/*page, which removes<button>elements. This is not easily testable in version 16.0 because no blocks contain<button>elements. However, starting from version 18.0, new blocks like theaccordionblock include buttons, and these are removed after saving aslide/*page when they are dropped into it.opw-4273436
Forward-Port-Of: #190620