[FW][FIX] stock_landed_costs: avoid uom user error from valid landed cost lines

[fw-bot]

Issue 1

Trying to validate a receipt related to a landed cost account line for
a product using a uom from a different uom category will raise a
userError that do not allow you to validate the receipt.

Steps to reproduce:

• Create a product:
  • real time property valuation
  • average cost method
  • on ordered quantities control policy
  • UOM from an other category han "Unit" e.g. kg
• Create and confirm a PO for 100 k units at 1.35 each
• Create an invoice for 23 k, receive 23k units and backorder
• Create a landed cost on the invoice for 23k units in the company currency units
• Post the invoice
• Create a second invoice for 27k units and post it
• Try to validate the receipt of the 27k units more units

UserError: The unit of measure Units defined on the order line doesn't belong to the same category as the unit of measure kg > defined on the product.

Cause of the issue:

Since Commit 32543ce The landed_cost account lines related to a given stock move are also considered in the _get_price_unit call of stock moves:

odoo/addons/purchase_stock/models/stock_move.py

Line 60 in 1b999e4

for invoice_line in line._get_po_line_invoice_lines_su():

odoo/addons/stock_landed_costs/models/purchase.py

Lines 11 to 16 in 1b999e4

	def _get_po_line_invoice_lines_su(self):
	po_line_invoices_lines = super()._get_po_line_invoice_lines_su()
	move = self.sudo().invoice_lines.move_id
	if move.landed_costs_ids.filtered(lambda lc: lc.state == 'done'):
	return po_line_invoices_lines | move.line_ids.filtered('is_landed_costs_line')
	return po_line_invoices_lines

However, the uom related to the landed cost account line might not match the uom category of the product related to the move. As such, this line will raise a UserError:

odoo/addons/purchase_stock/models/stock_move.py

Line 70 in da1f44c

invoiced_qty += invoice_line.product_uom_id._compute_quantity(invoice_line.quantity, line.product_id.uom_id)

odoo/addons/uom/models/uom_uom.py

Lines 223 to 227 in da1f44c

	if self != to_unit and self.category_id.id != to_unit.category_id.id:
	if raise_if_failure:
	raise UserError(_('The unit of measure %s defined on the order line doesn\'t belong to the same category as the unit of measure %s defined on the product. Please correct the unit of measure defined on the order line or on the product, they should belong to the same category.') % (self.name, to_unit.name))
	else:
	return qty

Issue 2

Steps to reproduce

• Create a product invoiced on ordered quantities
• Create a PO and a bill for it, post the bill
• Receipt half the quantity
• Add a landed cost product on the PO, create a second bill for this landed cost product. Create and validate the landed cost.
• Receipt the second half quantity.

Issue:

The valuation of the second transfer is too low

Cause of the Issue 2:

To get the price unit for "on ordered qty" policy, We compute the ratio of already receipt value on already invoiced value:

odoo/addons/purchase_stock/models/stock_move.py

Line 84 in 4f6353e

remaining_value = total_invoiced_value - receipt_value

The issue is the receipt value is increase by the landed costs value because the receipt valuation layer is linked to the landed cost valuation layer. But the product invoice line is not linked to the landed costs invoice line. Resulting in a invoice value under valuated.

This commit will ingnore the receipt values coming from landed costs so that the landed costs value will be added to the total invoiced value and not removed from the value here:

odoo/addons/purchase_stock/models/stock_move.py

Line 72 in cfb7a35

remaining_value = total_invoiced_value - receipt_value

if the landed cost has it's own invoice line.

Revert Commit 32543ce
Authored-by: Whenrow whe@odoo.com

Issue 1: opw-4389366
Issue 2: opw-4354498

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #191943
Forward-Port-Of: #191225

[robodoo]

[fw-bot]

This PR targets saas-18.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[lase-odoo]

robodoo r+

[fw-bot]

@lase-odoo @adwid child PR #191952 was modified / updated and has become a normal PR. This PR (and any of its parents) will need to be merged independently as approvals won't cross.