Skip to content

Conversation

AH-Yussef
Copy link
Contributor

In the template, /pos/ticket is concatenated to the base_url. But because /pos/ticket is a normal string inside the template, it is translated.

ticket-4447566

@AH-Yussef AH-Yussef self-assigned this Jan 3, 2025
@robodoo
Copy link
Contributor

robodoo commented Jan 3, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team and caburj and removed request for a team January 3, 2025 11:31
Copy link
Contributor

@brboi brboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Small note:
[FIX] point_of_sale: don't translate /pos/portal
should become
[FIX] point_of_sale: don't translate /pos/ticket

@brboi
Copy link
Contributor

brboi commented Jan 3, 2025

Oh, maybe there's something to do with the .po{t} files.
I am not really used to these kind of things though

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 3, 2025
@AH-Yussef AH-Yussef changed the title [FIX] point_of_sale: don't translate /pos/portal [FIX] point_of_sale: don't translate /pos/ticket Jan 3, 2025
In the template, /pos/ticket is concatenated to the base_url. But because /pos/ticket is a normal string inside the template, it is translated.

ticket-4447566
@AH-Yussef AH-Yussef force-pushed the saas-17.4-don't_translate_/pos/portal_alhy branch from 2a26149 to 63cecb2 Compare January 3, 2025 14:59
@caburj
Copy link
Contributor

caburj commented Jan 3, 2025

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 3, 2025
In the template, /pos/ticket is concatenated to the base_url. But because /pos/ticket is a normal string inside the template, it is translated.

ticket-4447566

closes #192308

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
robodoo pushed a commit that referenced this pull request Jan 3, 2025
In the template, /pos/ticket is concatenated to the base_url. But because /pos/ticket is a normal string inside the template, it is translated.

ticket-4447566

closes #192308

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
@robodoo robodoo closed this Jan 3, 2025
@fw-bot fw-bot deleted the saas-17.4-don't_translate_/pos/portal_alhy branch January 17, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants