[FIX] web: not export readonly fields in import-compatible export #192486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
taqu-odoo
force-pushed
the
18.0-opw-4446090-web_import_compatible_export-taqu
branch
from
6c329f6 to
4bb8d98
Compare
|
For me it doesn't looks like it's wrong, but this should be reviewed by framework-py team I think. |
C3POdoo
requested review from
a team,
BastienFafchamps,
Julien00859,
aab-odoo and
rco-odoo
and removed request for
a team
kmagusiak
approved these changes
Jan 9, 2025
|
Thank you for the fix @taqu-odoo . What about the |
Issue ----- Read-only fields appear in the export menu when the "I want to update data (import-compatible export)" checkbox is active. Cause ----- The `readonly` key is missing from the field dictionnary leading to all fields being considered as not read-only. https://github.com/odoo/odoo/blob/a546e2e5a87c311bef054ca4a6909e63d70c91fd/addons/web/controllers/export.py#L389-L390 Issue from 2b87eff since only some attributes of the fields are fetched. opw-4446090
taqu-odoo
force-pushed
the
18.0-opw-4446090-web_import_compatible_export-taqu
branch
from
4bb8d98 to
f577b65
Compare
|
@robodoo r+ |
|
@taqu-odoo @ryv-odoo 'ci/runbot' failed on this reviewed PR. |
This was referenced Jan 11, 2025
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Jan 24, 2025
Issue ----- Read-only fields appear in the export menu when the "I want to update data (import-compatible export)" checkbox is active. Cause ----- The `readonly` key is missing from the field dictionnary leading to all fields being considered as not read-only. https://github.com/odoo/odoo/blob/a546e2e5a87c311bef054ca4a6909e63d70c91fd/addons/web/controllers/export.py#L389-L390 Issue from 2b87eff since only some attributes of the fields are fetched. opw-4446090 closes odoo/odoo#192486 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
StephaneMangin
pushed a commit
to camptocamp/odoo
that referenced
this pull request
Feb 6, 2025
Issue ----- Read-only fields appear in the export menu when the "I want to update data (import-compatible export)" checkbox is active. Cause ----- The `readonly` key is missing from the field dictionnary leading to all fields being considered as not read-only. https://github.com/odoo/odoo/blob/a546e2e5a87c311bef054ca4a6909e63d70c91fd/addons/web/controllers/export.py#L389-L390 Issue from 2b87eff since only some attributes of the fields are fetched. opw-4446090 closes odoo#192486 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Read-only fields appear in the export menu when the "I want to update data (import-compatible export)" checkbox is active.
Cause
The
readonlykey is missing from the field dictionnary leading to all fields being considered as not read-only.odoo/addons/web/controllers/export.py
Lines 389 to 390 in a546e2e
opw-4446090