[IMP] auth_signup: do not spam the user on new connection #193181

std-odoo · 2025-01-10T09:28:32Z

Purpose

When a user has TOTP enabled, on its first login, he receives 2 emails

"New Connection" email, sent when he enters his credentials
"Trusted Device Added", if he checked "Don't ask again on this device"

Because the user needs to login to add a device, and that he will receive the
"New Connection" email anyway, we don't notify when adding a new device.

We merge the information (like location, etc) in the "New Connection" email
template, and we also make all notification emails consistent (same template, same
information).

Task-4070794

robodoo · 2025-01-10T09:28:35Z

reth-odoo

Looks pretty clean as far as this is doable.

Would maybe add a test case around the test you updated to cover this feature if it's not too finicky to set up

Sadly I don't think we can avoid some kind of hacky global storage :/

addons/auth_signup/models/res_users.py

addons/auth_totp_mail/controllers/home.py

std-odoo

@reth-odoo Hi :)

Thanks for the validation :) I did the changes, and answered

Cheers

addons/auth_signup/models/res_users.py

addons/auth_totp_mail/controllers/home.py

reth-odoo

Indeed, too bad we don't have a warning regardless of TOTP to be honest
Linting comment and one for the session key again

Greening for testing already

addons/auth_totp_mail/models/auth_totp_device.py

addons/auth_totp_mail/tests/test_notify_security_update_totp.py

std-odoo

@reth-odoo Good idea for the pop :) Done :)

awa-odoo

Hello @std-odoo

Left some picky remarks & questions.
Overall a very clean work!

Thanks & cheers!

addons/auth_signup/models/res_users.py

addons/auth_totp/models/res_users.py

addons/auth_totp_mail/tests/test_notify_security_update_totp.py

addons/mail/data/security_notifications_templates.xml

addons/auth_totp_mail/data/security_notifications_template.xml

addons/mail/models/res_users.py

std-odoo

@awa-odoo Hi :)

I did the changes :)

Cheers

addons/auth_signup/models/res_users.py

addons/auth_totp_mail/data/security_notifications_template.xml

addons/auth_totp_mail/tests/test_notify_security_update_totp.py

addons/mail/models/res_users.py

addons/mail/data/security_notifications_templates.xml

awa-odoo

LGTM, just one extra cleaning comment 🧦

addons/auth_totp/models/res_users.py

std-odoo

@awa-odoo Change done :)

awa-odoo · 2025-02-07T13:57:26Z

@std-odoo

instead of waiting for the CROM to run

I like CROM better, we should rename all CRONs to CROMs !

std-odoo · 2025-02-07T13:59:55Z

@awa-odoo Good catch 😅
(language tool rale for CRON but not for CROM 😆)

Purpose ======= When a user has TOTP enabled, on its first login, he receives 2 emails - "New Connection" email, sent when he enters his credentials - "Trusted Device Added", if he checked "Don't ask again on this device" Because the user needs to login to add a device, and that he will receive the "New Connection" email anyway, we don't notify when adding a new device. We merge the information (like location, etc) in the "New Connection" email template, and we also make all notification emails consistent (same template, same information). Make the "Ask Password" and "TOTP settings" dialog a bit smaller. For all security notification, send right away the notification (instead of waiting for the CRON to run). Task-4070794

awa-odoo · 2025-02-10T10:17:50Z

@robodoo r+

Purpose ======= When a user has TOTP enabled, on its first login, he receives 2 emails - "New Connection" email, sent when he enters his credentials - "Trusted Device Added", if he checked "Don't ask again on this device" Because the user needs to login to add a device, and that he will receive the "New Connection" email anyway, we don't notify when adding a new device. We merge the information (like location, etc) in the "New Connection" email template, and we also make all notification emails consistent (same template, same information). Make the "Ask Password" and "TOTP settings" dialog a bit smaller. For all security notification, send right away the notification (instead of waiting for the CRON to run). Task-4070794 closes #193181 Related: odoo/upgrade#7077 Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

tde-banana-odoo · 2025-02-17T11:16:13Z

C3POdoo added the RD research & development, internal work label Jan 10, 2025

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch 5 times, most recently from 8c7f9f1 to 22595bf Compare January 16, 2025 09:00

C3POdoo requested review from a team January 16, 2025 09:03

std-odoo changed the title ~~WIP~~ [IMP] auth_signup: do not spam the user on new connection Jan 16, 2025

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch 8 times, most recently from a2ce264 to add1e9e Compare January 16, 2025 11:35

reth-odoo reviewed Jan 22, 2025

View reviewed changes

addons/auth_signup/models/res_users.py Outdated Show resolved Hide resolved

addons/auth_totp_mail/controllers/home.py Outdated Show resolved Hide resolved

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch 2 times, most recently from 9936b7b to 218c65b Compare January 23, 2025 08:01

std-odoo commented Jan 23, 2025

View reviewed changes

addons/auth_signup/models/res_users.py Outdated Show resolved Hide resolved

addons/auth_totp_mail/controllers/home.py Outdated Show resolved Hide resolved

reth-odoo reviewed Jan 23, 2025

View reviewed changes

addons/auth_totp_mail/models/auth_totp_device.py Outdated Show resolved Hide resolved

addons/auth_totp_mail/tests/test_notify_security_update_totp.py Outdated Show resolved Hide resolved

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch from 218c65b to f1585e5 Compare January 23, 2025 09:58

std-odoo commented Jan 23, 2025

View reviewed changes

seb-odoo removed the request for review from a team January 23, 2025 10:00

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch 3 times, most recently from 97dd66d to 06748d0 Compare February 5, 2025 10:16

C3POdoo requested review from a team, rco-odoo and xmo-odoo and removed request for a team February 6, 2025 09:26

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch 2 times, most recently from 9a25a41 to f1dceb6 Compare February 6, 2025 12:12

awa-odoo reviewed Feb 7, 2025

View reviewed changes

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch 7 times, most recently from 5cf1e98 to 228f30d Compare February 7, 2025 10:50

std-odoo commented Feb 7, 2025

View reviewed changes

awa-odoo reviewed Feb 7, 2025

View reviewed changes

addons/auth_totp/models/res_users.py Outdated Show resolved Hide resolved

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch from 228f30d to ee3914c Compare February 7, 2025 13:13

std-odoo commented Feb 7, 2025

View reviewed changes

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch from ee3914c to c1c3714 Compare February 7, 2025 13:59

std-odoo force-pushed the master-auth_totp-dont-spam-on-new-device-std branch from c1c3714 to ba167b1 Compare February 10, 2025 07:41

robodoo added the 18.2 label Feb 10, 2025

robodoo temporarily deployed to merge February 10, 2025 13:58 Inactive

robodoo closed this Feb 10, 2025

fw-bot deleted the master-auth_totp-dont-spam-on-new-device-std branch February 24, 2025 13:59

[IMP] auth_signup: do not spam the user on new connection #193181

[IMP] auth_signup: do not spam the user on new connection #193181

Uh oh!

Conversation

std-odoo commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Uh oh!

robodoo commented Jan 10, 2025

Uh oh!

reth-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

std-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

reth-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

std-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

awa-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

std-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

awa-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

std-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

awa-odoo commented Feb 7, 2025

Uh oh!

std-odoo commented Feb 7, 2025

Uh oh!

awa-odoo commented Feb 10, 2025

Uh oh!

tde-banana-odoo commented Feb 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

std-odoo commented Jan 10, 2025 •

edited

Loading