[FW][FIX] mail: no autofocus on composer on mobile #194308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, when opening a channel on mobile the composer gets automatically focused. This is not a problem on desktop, but when on mobile it triggers the opening of the system keyboard, occupying half the screen and requiring a "back" command to close it. This happens because the function that opens the chat window will put focus on the composer. This commit fixes the issue by only focusing the composer when not on mobile. task-4115728 X-original-commit: b5741f1
|
|
robodoo
added
forwardport
|
@Atovange @alexkuhn cherrypicking of pull request #194122 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
Already fixed by #176557 |
alexkuhn
deleted the
saas-17.4-17.0-autofocus-composer-mobile-gito-HM8R-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when opening a channel on mobile the composer gets automatically focused.
This is not a problem on desktop, but when on mobile it triggers the opening of the system keyboard, occupying half the screen and requiring a "back" command to close it.
This happens because the function that opens the chat window will put focus on the composer.
This commit fixes the issue by only focusing the composer when not on mobile.
task-4115728
Forward-Port-Of: #194274
Forward-Port-Of: #194122