[IMP] hr_contract, hr_work_entry: improve ux for contract and work entry #194330
Conversation
|
|
ravb-odoo
force-pushed
the
master-hr-payroll-ux-improvement-ravb
branch
from
0cdd086 to
2929461
Compare
| widget="state_selection" readonly="0"/> | ||
| </h1> | ||
| <h2> | ||
| <h2 class="d-none"> |
There was a problem hiding this comment.
Isn't invisible="1" working here?
There was a problem hiding this comment.
We can't use invisible because it removes the entire <h2> tag from the HTML structure, causing some tours and test cases to fail when searching for it. Instead, using d-none will hide it from the UI while keeping it in the structure, ensuring that the tours and tests still pass.
There was a problem hiding this comment.
And couldn't we adapt the tour instead ?
ravb-odoo
force-pushed
the
master-hr-payroll-ux-improvement-ravb
branch
3 times, most recently
from
bc40377 to
fb6e214
Compare
ravb-odoo
force-pushed
the
master-hr-payroll-ux-improvement-ravb
branch
4 times, most recently
from
1ed6319 to
e2d0a00
Compare
There was a problem hiding this comment.
seems like a really bad way to do this hardcoding stuff especially position of the the template layering is not the way to go it's basically killing a fly with a bazooka
There was a problem hiding this comment.
I think that you can just move the ribbon position in the template
There was a problem hiding this comment.
what is the point of having a non empty header that cannot ever be visible?
There was a problem hiding this comment.
what's the point of a none display unempty stuff ?
There was a problem hiding this comment.
We need to use d-none because it prevents extra space from appearing between the name and employee_id fields in contract form view. Using invisible causes some tours and test cases to fail when searching for the field. Instead, d-none hides it from the UI while keeping it in the structure, ensuring that the tours and tests continue to pass.
ravb-odoo
force-pushed
the
master-hr-payroll-ux-improvement-ravb
branch
5 times, most recently
from
3e87649 to
928a65e
Compare
ravb-odoo
force-pushed
the
master-hr-payroll-ux-improvement-ravb
branch
from
928a65e to
7d7bdb5
Compare
| widget="state_selection" readonly="0"/> | ||
| </h1> | ||
| <h2> | ||
| <h2 class="d-none"> |
There was a problem hiding this comment.
And couldn't we adapt the tour instead ?
There was a problem hiding this comment.
| invisible="contracts_count < 2" | |
| invisible="contracts_count <= 1" |
ravb-odoo
force-pushed
the
master-hr-payroll-ux-improvement-ravb
branch
4 times, most recently
from
11f9fa6 to
d430b25
Compare
This PR improves the ux and functionality for both the contract and work entry form views. task-4334973
tivisse
force-pushed
the
master-hr-payroll-ux-improvement-ravb
branch
from
d430b25 to
d67c0d6
Compare
|
@robodoo r+ |
This PR improves the ux and functionality for both the contract and work entry form views. task-4334973 closes #194330 Related: odoo/enterprise#77409 Related: odoo/upgrade#7089 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
6 participants
This PR improves the ux and functionality for both the contract and work entry form views.
task-4334973