[FIX] point_of_sale: add additional field in product loader #194637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue --> Using the 'product.product.name' field in loyalty.reward.discount_product_domain that is not added via the `_loader_params_product_product` loader causes an error in the matchCondition function https://github.com/odoo/odoo/blob/9b0f528aa02743372934df8e64d1cc0ad74903b6/addons/web/static/src/core/domain.js#L331 where variable fieldValue is undefined if the field is not available. Solution --> Adding the `name` field search pararmeters in the `_loader_params_product_product` similar to odoo#186804 opw-4410460
|
|
C3POdoo
requested review from
a team and
davidmonnom
and removed request for
a team
robodoo
pushed a commit
that referenced
this pull request
Jan 22, 2025
Issue --> Using the 'product.product.name' field in loyalty.reward.discount_product_domain that is not added via the `_loader_params_product_product` loader causes an error in the matchCondition function https://github.com/odoo/odoo/blob/9b0f528aa02743372934df8e64d1cc0ad74903b6/addons/web/static/src/core/domain.js#L331 where variable fieldValue is undefined if the field is not available. Solution --> Adding the `name` field search pararmeters in the `_loader_params_product_product` similar to #186804 opw-4410460 closes #194637 Signed-off-by: David Monnom (moda) <moda@odoo.com>
This was referenced Jan 22, 2025
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 24, 2025
Issue --> Using the 'product.product.name' field in loyalty.reward.discount_product_domain that is not added via the `_loader_params_product_product` loader causes an error in the matchCondition function https://github.com/odoo/odoo/blob/9b0f528aa02743372934df8e64d1cc0ad74903b6/addons/web/static/src/core/domain.js#L331 where variable fieldValue is undefined if the field is not available. Solution --> Adding the `name` field search pararmeters in the `_loader_params_product_product` similar to odoo#186804 opw-4410460 closes odoo#194637 Signed-off-by: David Monnom (moda) <moda@odoo.com>
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/odoo-odoo
that referenced
this pull request
Jan 25, 2025
Issue --> Using the 'product.product.name' field in loyalty.reward.discount_product_domain that is not added via the `_loader_params_product_product` loader causes an error in the matchCondition function https://github.com/odoo/odoo/blob/9b0f528aa02743372934df8e64d1cc0ad74903b6/addons/web/static/src/core/domain.js#L331 where variable fieldValue is undefined if the field is not available. Solution --> Adding the `name` field search pararmeters in the `_loader_params_product_product` similar to odoo#186804 opw-4410460 closes odoo#194637 Signed-off-by: David Monnom (moda) <moda@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue -->
Using the 'product.product.name' field in loyalty.reward.discount_product_domain that is not added via the
_loader_params_product_productloader causes an error in the matchCondition functionodoo/addons/web/static/src/core/domain.js
Line 331 in 9b0f528
Solution -->
Adding the
namefield search parameters in the_loader_params_product_productsimilar to #186804opw-4410460