[IMP] point_of_sale: partner list infinite scroll #194710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix multiple issues with partner list : - The list was not updated when scrolling down - When searching customers, the partner list could contains duplicate (because before this commit a `Set` structure was used to store objects. This wasn't working as expecting because in JS a Set use references of objects to compare them (now we use a set to store unique IDs). - Traceback occured when following these steps : - Open "Customer" popup - Type "ss" - Press "enter" => Traceback Here is how it works now: - When reaching 80% (scroll) of the partner list, we fetch 100 more partners and add them to the list - When typing in search bar: search inside the fetched partner list - Press enter in search bar: fetch new customer matching the search from database task-id: 4489331
|
|
robodoo
pushed a commit
that referenced
this pull request
Jan 22, 2025
Fix multiple issues with partner list : - The list was not updated when scrolling down - When searching customers, the partner list could contains duplicate (because before this commit a `Set` structure was used to store objects. This wasn't working as expecting because in JS a Set use references of objects to compare them (now we use a set to store unique IDs). - Traceback occured when following these steps : - Open "Customer" popup - Type "ss" - Press "enter" => Traceback Here is how it works now: - When reaching 80% (scroll) of the partner list, we fetch 100 more partners and add them to the list - When typing in search bar: search inside the fetched partner list - Press enter in search bar: fetch new customer matching the search from database closes #194710 Task-id: 4489331 Signed-off-by: David Monnom (moda) <moda@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiple issues with partner list :
Setstructure was used to store objects. This wasn't working as expecting because in JS a Set use references of objects to compare them (now we use a set to store unique IDs).Here is how it works now:
task-id: 4489331
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr