Skip to content

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Feb 8, 2025

Steps to reproduce:

  • In Sales app, create a new invoice with one product;
  • Post the invoice without validating it;
  • Print invoice without payment from action button.

Issue:
The taxes column's header is "start aligned" as its content and the other columns are "end aligned".

Expected:
Column headers should be harmonized and have a consistent display as per :

<th name="th_description" class="text-start">Description</th>
<th name="th_quantity" class="text-end text-nowrap">Quantity</th>
<th name="th_priceunit" class="text-end text-nowrap">Unit Price</th>
<th name="th_discount" t-if="display_discount" class="text-end">
<span>Disc.%</span>
</th>
<th name="th_taxes" class="text-end">Taxes</th>
<th name="th_subtotal" class="text-end">
<span>Amount</span>
</th>

Cause:
The view sets the header alignement on start.

opw-4380680


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #193394

Steps to reproduce:

- In Sales app, create a new invoice with one product;
- Post the invoice without validating it;
- Print invoice without payment from action button.

Issue:
The taxes column's header is "start aligned" as its content and the other columns are "end aligned".

Expected:
Column headers should be harmonized and have a consistent display.

Cause:
The view sets the header alignement on start.

opw-4380680

X-original-commit: 6054563
@robodoo
Copy link
Contributor

robodoo commented Feb 8, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 8, 2025

This PR targets saas-17.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Feb 8, 2025
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Feb 8, 2025
@fw-bot
Copy link
Contributor Author

fw-bot commented Feb 8, 2025

@barracudapps @qdp-odoo the next pull request (#197079) is in conflict. You can merge the chain up to here by saying

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@barracudapps
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Feb 9, 2025

@barracudapps @qdp-odoo staging failed: timed out (>120 minutes)

@barracudapps
Copy link
Contributor

@robodoo retry

robodoo pushed a commit that referenced this pull request Feb 9, 2025
Steps to reproduce:

- In Sales app, create a new invoice with one product;
- Post the invoice without validating it;
- Print invoice without payment from action button.

Issue:
The taxes column's header is "start aligned" as its content and the other columns are "end aligned".

Expected:
Column headers should be harmonized and have a consistent display.

Cause:
The view sets the header alignement on start.

opw-4380680

closes #197072

X-original-commit: 6054563
Signed-off-by: Quentin De Paoli (qdp) <qdp@odoo.com>
Signed-off-by: Pierre Lamotte (pila) <pila@odoo.com>
@robodoo
Copy link
Contributor

robodoo commented Feb 9, 2025

@barracudapps @qdp-odoo staging failed: ci/runbot on fb4398818f8b0f28237a57d3196f5b0b3cd3ee08 (view more at https://runbot.odoo.com/runbot/build/74756661)

@barracudapps
Copy link
Contributor

@robodoo retry

robodoo pushed a commit that referenced this pull request Feb 9, 2025
Steps to reproduce:

- In Sales app, create a new invoice with one product;
- Post the invoice without validating it;
- Print invoice without payment from action button.

Issue:
The taxes column's header is "start aligned" as its content and the other columns are "end aligned".

Expected:
Column headers should be harmonized and have a consistent display.

Cause:
The view sets the header alignement on start.

opw-4380680

closes #197072

X-original-commit: 6054563
Signed-off-by: Quentin De Paoli (qdp) <qdp@odoo.com>
Signed-off-by: Pierre Lamotte (pila) <pila@odoo.com>
@robodoo robodoo closed this Feb 9, 2025
@fw-bot fw-bot deleted the saas-17.4-17.0-opw-4380680-harmonize_documents_headers_position-pila-415063-fw branch February 23, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants