[FIX] purchase: match only invoice lines in matching process #197637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
requested review from
a team and
svs-odoo
and removed request for
a team
|
Hello, Would it be possible to have this PR reviewed promptly? It is currently blocking the loading of certain IT bills for our clients. Thank you! |
|
@svs-odoo Hello, could I get an update? Thanks 🙂 |
svs-odoo
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Hello @LouisGobert
Thanks for the fix, it looks good to me !
I let you two small comments about the test
LouisGobert
force-pushed
the
17.0-purchase-fix-match-only-invoice-lines-loug
branch
from
07339a2 to
180cd65
Compare
|
@LouisGobert rebase your branch please |
Currently, an error can occur in `_find_matching_po_and_inv_lines` when some invoice lines have a price_unit of 0. This happens because the matching logic sorts and matches lines by `(price_unit, qty)`, leading to "Journal Items" (`line_ids`) being incorrectly matched with purchase order lines. The issue arises because the `_find_matching_po_and_inv_lines` function checks all `line_ids`, instead of only `invoice_line_ids`. When a PO line has a price_unit of 0, it might match with a line that isn't an actual invoice line. As a result, `unmatched_lines` becomes incorrect, and it could remove a valid invoice line. Then, later, when calculating `inv_and_po_lines`, the process only considers `invoice_line_ids`. Since no matching line is found, an error occurs when attempting to delete the line (id is False). Steps to reproduce: 1. Create a purchase order with: - 1 product A with price_unit = 0 2. Confirm the purchase order. 3. Upload an EDI XML bill (e.g., IT localization) with: - A reference to the purchase order - 1 product B with price_unit = 100 Since all bill lines are processed, a tax line or a payment term line might incorrectly match with the PO line, causing the error. opw-4513869
LouisGobert
force-pushed
the
17.0-purchase-fix-match-only-invoice-lines-loug
branch
from
180cd65 to
3626b1c
Compare
|
Done :) |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2025
Currently, an error can occur in `_find_matching_po_and_inv_lines` when some invoice lines have a price_unit of 0. This happens because the matching logic sorts and matches lines by `(price_unit, qty)`, leading to "Journal Items" (`line_ids`) being incorrectly matched with purchase order lines. The issue arises because the `_find_matching_po_and_inv_lines` function checks all `line_ids`, instead of only `invoice_line_ids`. When a PO line has a price_unit of 0, it might match with a line that isn't an actual invoice line. As a result, `unmatched_lines` becomes incorrect, and it could remove a valid invoice line. Then, later, when calculating `inv_and_po_lines`, the process only considers `invoice_line_ids`. Since no matching line is found, an error occurs when attempting to delete the line (id is False). Steps to reproduce: 1. Create a purchase order with: - 1 product A with price_unit = 0 2. Confirm the purchase order. 3. Upload an EDI XML bill (e.g., IT localization) with: - A reference to the purchase order - 1 product B with price_unit = 100 Since all bill lines are processed, a tax line or a payment term line might incorrectly match with the PO line, causing the error. opw-4513869 closes #197637 Signed-off-by: Steve Van Essche <svs@odoo.com>
|
@LouisGobert @svs-odoo staging failed: ci/runbot on 2253a49e627daa156f9f872e1f0b6796c6539a9e (view more at https://runbot.odoo.com/runbot/build/77376053) |
|
@robodoo retry |
|
@LouisGobert @svs-odoo staging failed: ci/runbot on 90ac32c0942e36c52b83b192a0288ab206ebac83 (view more at https://runbot.odoo.com/runbot/build/77383662) |
|
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2025
Currently, an error can occur in `_find_matching_po_and_inv_lines` when some invoice lines have a price_unit of 0. This happens because the matching logic sorts and matches lines by `(price_unit, qty)`, leading to "Journal Items" (`line_ids`) being incorrectly matched with purchase order lines. The issue arises because the `_find_matching_po_and_inv_lines` function checks all `line_ids`, instead of only `invoice_line_ids`. When a PO line has a price_unit of 0, it might match with a line that isn't an actual invoice line. As a result, `unmatched_lines` becomes incorrect, and it could remove a valid invoice line. Then, later, when calculating `inv_and_po_lines`, the process only considers `invoice_line_ids`. Since no matching line is found, an error occurs when attempting to delete the line (id is False). Steps to reproduce: 1. Create a purchase order with: - 1 product A with price_unit = 0 2. Confirm the purchase order. 3. Upload an EDI XML bill (e.g., IT localization) with: - A reference to the purchase order - 1 product B with price_unit = 100 Since all bill lines are processed, a tax line or a payment term line might incorrectly match with the PO line, causing the error. opw-4513869 closes #197637 Signed-off-by: Steve Van Essche <svs@odoo.com>
This was referenced Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an error can occur in
_find_matching_po_and_inv_lineswhen some invoice lines have a price_unit of 0. This happens because the matching logic sorts and matches lines by(price_unit, qty), leading to "Journal Items" (line_ids) being incorrectly matched with purchase order lines.The issue arises because the
_find_matching_po_and_inv_linesfunction checks allline_ids, instead of onlyinvoice_line_ids. When a PO line has a price_unit of 0, it might match with a line that isn't an actual invoice line. As a result,unmatched_linesbecomes incorrect, and it could remove a valid invoice line. Then, later, when calculatinginv_and_po_lines, the process only considersinvoice_line_ids. Since no matching line is found, an error occurs when attempting to delete the line (id is False).Steps to reproduce:
Since all bill lines are processed, a tax line or a payment term line might incorrectly match with the PO line, causing the error.
opw-4513869